-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix flaky test-hash-seed #38059
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test can take a long time to run. Some of our CI hosts are configured to consider the task stalled if there is no output for 3 minutes. TO prevent that from canceling this test and the entire test suite, output something every 60 seconds or so. Refs: nodejs#34289
nodejs-github-bot
added
needs-ci
PRs that need a full CI run.
test
Issues and PRs related to the tests.
labels
Apr 3, 2021
Trott
added
the
flaky-test
Issues and PRs related to the tests with unstable failures on the CI.
label
Apr 3, 2021
targos
approved these changes
Apr 3, 2021
2 tasks
cjihrig
approved these changes
Apr 3, 2021
Alas, this doesn't fix it on CI because the |
This was referenced Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
flaky-test
Issues and PRs related to the tests with unstable failures on the CI.
needs-ci
PRs that need a full CI run.
test
Issues and PRs related to the tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test can take a long time to run. Some of our CI hosts are configured
to consider the task stalled if there is no output for 3 minutes. TO
prevent that from canceling this test and the entire test suite, output
something every 60 seconds or so.
Refs: #34289