Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: remove KeyObjectData::CreateSecret overload #38067

Merged
merged 1 commit into from
Apr 6, 2021
Merged

src: remove KeyObjectData::CreateSecret overload #38067

merged 1 commit into from
Apr 6, 2021

Conversation

tniessen
Copy link
Member

@tniessen tniessen commented Apr 4, 2021

This function is unused and there is not much potential for using it in the current codebase.

This is the only invocation of CreateSecret that could use this overload instead of calling ToCopy, and it seems appropriate to explicitly call ToCopy here.

node/src/crypto/crypto_keys.cc

Lines 946 to 950 in f562ec6

case kKeyTypeSecret: {
CHECK_EQ(args.Length(), 2);
ArrayBufferOrViewContents<char> buf(args[1]);
key->data_ = KeyObjectData::CreateSecret(buf.ToCopy());
break;

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Apr 4, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37137/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37156/

@tniessen tniessen added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Apr 5, 2021
@tniessen @Trott
src: remove KeyObjectData::CreateSecret overload
66c8f76 
This function is unused and there is not much potential for using
it in the current codebase.

PR-URL: nodejs#38067
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott Trott force-pushed the src-remove-keyobjectdata-createsecret-arraybufferorviewcontents branch from 9b4d787 to 66c8f76 Compare April 6, 2021 01:17
@Trott
Copy link
Member

Trott commented Apr 6, 2021

Landed in 66c8f76

@Trott Trott merged commit 66c8f76 into nodejs:master Apr 6, 2021
@BethGriggs BethGriggs mentioned this pull request Apr 12, 2021
Merged
@tniessen tniessen deleted the src-remove-keyobjectdata-createsecret-arraybufferorviewcontents branch October 7, 2021 16:51
@molllyn1 molllyn1 mentioned this pull request Jun 8, 2023
Open
This was referenced Jun 8, 2023
Open
Open
@ron-a20 ron-a20 mentioned this pull request Jun 8, 2023
Open
@baby636 baby636 mentioned this pull request Jun 9, 2023
Open
@137717unity 137717unity mentioned this pull request Jun 9, 2023
Open
@wedataintelligence wedataintelligence mentioned this pull request Jun 9, 2023
Open
@kissofire kissofire mentioned this pull request Jun 25, 2023
Open
@kissofire kissofire mentioned this pull request Sep 28, 2023
Open
@molllyn1 molllyn1 mentioned this pull request Sep 28, 2023
Open
@ron-a20 ron-a20 mentioned this pull request Sep 28, 2023
Open
@137717unity 137717unity mentioned this pull request Sep 28, 2023
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request Sep 28, 2023
Open
@baby636 baby636 mentioned this pull request Sep 28, 2023
Open
@wedataintelligence wedataintelligence mentioned this pull request Sep 29, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panva panva panva approved these changes

@Trott Trott Trott approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tniessen @nodejs-github-bot @Trott @panva @cjihrig @targos