Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: skip test-hash-seed on armv6 and armv7 #38071

Closed
wants to merge 1 commit into from
Closed

test: skip test-hash-seed on armv6 and armv7 #38071

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Apr 4, 2021

The test is too slow to run on the Raspberry Pi bots. (It takes over 900
seconds to run on Pi 3 bots and even more than that on Pi 2 bots.) Skip
it on armv6 and armv7.

Refs: #34289

@Trott
test: skip test-hash-seed on armv6 and armv7
22e3d2d 
The test is too slow to run on the Raspberry Pi bots. (It takes over 900
seconds to run on Pi 3 bots and even more than that on Pi 2 bots.) Skip
it on armv6 and armv7.

Refs: nodejs#34289
@Trott Trott added arm Issues and PRs related to the ARM platform. flaky-test Issues and PRs related to the tests with unstable failures on the CI. labels Apr 4, 2021
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Apr 4, 2021
@targos
Copy link
Member

targos commented Apr 4, 2021

Maybe we should move it to test/v8-updates instead ?

@Trott
Copy link
Member Author

Trott commented Apr 6, 2021

Maybe we should move it to test/v8-updates instead ?

Are those tests run on CI only during the V8 update process or something like that?

test/v8-updates/testcfg.py has the tests there set to run in parallel. This doesn't seem like a great candidate for that given how CPU intensive it can be. We can move it there and see if it causes issues or we can be cautious and change the v8-updates tests to run in sequence. (I guess since there's only one test in there, it's never been an issue to even think about before.)

@Trott Trott closed this Apr 10, 2021
@Trott Trott deleted the arm-hash branch September 25, 2022 17:08
@molllyn1 molllyn1 mentioned this pull request Jun 8, 2023
Open
This was referenced Jun 8, 2023
Open
Open
@ron-a20 ron-a20 mentioned this pull request Jun 8, 2023
Open
@baby636 baby636 mentioned this pull request Jun 9, 2023
Open
@137717unity 137717unity mentioned this pull request Jun 9, 2023
Open
@wedataintelligence wedataintelligence mentioned this pull request Jun 9, 2023
Open
@kissofire kissofire mentioned this pull request Jun 25, 2023
Open
@kissofire kissofire mentioned this pull request Sep 28, 2023
Open
@molllyn1 molllyn1 mentioned this pull request Sep 28, 2023
Open
@ron-a20 ron-a20 mentioned this pull request Sep 28, 2023
Open
@137717unity 137717unity mentioned this pull request Sep 28, 2023
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request Sep 28, 2023
Open
@baby636 baby636 mentioned this pull request Sep 28, 2023
Open
@wedataintelligence wedataintelligence mentioned this pull request Sep 29, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielleadams danielleadams danielleadams approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
arm Issues and PRs related to the ARM platform. flaky-test Issues and PRs related to the tests with unstable failures on the CI. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Trott @targos @jasnell @danielleadams @nodejs-github-bot