test: correct test comment #38095
Closed
test: correct test comment #38095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This corrects a comment on the signal type used in the test.
nodejs-github-bot
added
needs-ci
benjamingr
approved these changes
Apr 5, 2021
|
Hi @evanlucas 👋 hope life is going great :) |
lpinca
approved these changes
Apr 5, 2021
cjihrig
approved these changes
Apr 6, 2021
jasnell
approved these changes
Apr 6, 2021
|
There's no reason to make this one wait the 48 hours to land. Please 👍🏻 to fast-track |
evanlucas
added a commit
that referenced
this pull request
Apr 6, 2021
This corrects a comment on the signal type used in the test. PR-URL: #38095 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in e155b1f |
marsonya
added
author ready
|
Sorry about the tag after landing. It was a Pull request filter/search mixup. |
targos
pushed a commit
that referenced
this pull request
May 1, 2021
This corrects a comment on the signal type used in the test. PR-URL: #38095 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This corrects a comment on the signal type used in the test.