Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: replaced intended deriveKey parameter instead of deriveBits #38123

Closed
wants to merge 1 commit into from

Conversation

hassaanp
Copy link
Contributor

@hassaanp hassaanp commented Apr 7, 2021

Example intends to use deriveKey but uses deriveBits to the subtle.importKey method which does not produce the required response.

Fixes: #38115

Example intends to use deriveKey but uses deriveBits to the subtle.importKey method which does not produce the required response.

Fixes: nodejs#38115
@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. labels Apr 7, 2021
@tniessen
Copy link
Member

tniessen commented Apr 7, 2021

@hassaanp This doesn't appear to fix #38115, which is twofold. The commit message and PR description should use Refs instead of Fixes in that case.

@panva
Copy link
Member

panva commented Apr 8, 2021

I've opened #38148 to address all the issues (and more) from #38115

@panva
Copy link
Member

panva commented Apr 12, 2021

Resolved by 896dc39

@panva panva closed this Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Web Crypto API - subtle.deriveKey doesn't return promise with ArrayBuffer + doc example bug
7 participants