Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix typo in crypto #38130

Closed
wants to merge 1 commit into from
Closed

doc: fix typo in crypto #38130

wants to merge 1 commit into from

Conversation

arkerone
Copy link
Contributor

@arkerone arkerone commented Apr 7, 2021

I found a two typos in crypto documentation :

  • keyLenth -> keyLength
  • ivLenth -> ivLength

@arkerone
doc: fix typo in crypto
fc208ca 
-change "keyLenth" to "keyLength"
-change "ivLenth" to "ivLength"
@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. labels Apr 7, 2021
@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 7, 2021
@jasnell jasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 7, 2021
@jasnell
Copy link
Member

jasnell commented Apr 7, 2021

This shouldn't need to wait the 48 hours to land. Please 👍🏻 to fast-track

@jasnell
Copy link
Member

jasnell commented Apr 7, 2021

Landed in 4bc8f75

@jasnell jasnell closed this Apr 7, 2021
jasnell pushed a commit that referenced this pull request Apr 7, 2021
@arkerone @jasnell
doc: fix typo in crypto
4bc8f75 
-change "keyLenth" to "keyLength"
-change "ivLenth" to "ivLength"

PR-URL: #38130
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@arkerone arkerone deleted the doc/fix-typo-crypto branch April 8, 2021 12:22
@BethGriggs BethGriggs mentioned this pull request Apr 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MJjames43 MJjames43 MJjames43 approved these changes

@HarshithaKP HarshithaKP HarshithaKP approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

@richardlau richardlau richardlau approved these changes

@tniessen tniessen tniessen approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@arkerone @jasnell @tniessen @richardlau @RaisinTen @HarshithaKP @MJjames43 @targos @nodejs-github-bot