-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: update llhttp to 5.1.0 #38146
deps: update llhttp to 5.1.0 #38146
Conversation
46b44a3
to
84c9f0c
Compare
84c9f0c
to
24fd191
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Should this be backported?
@mcollina possibly, but I the |
I've added a bunch of don't land labels to match this. |
Landed in 6a1986d. Thank you! |
PR-URL: #38146 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Daniele Belardi <dwon.dnl@gmail.com>
It looks like this has broken the tests for |
PR-URL: nodejs#38146 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Daniele Belardi <dwon.dnl@gmail.com> # Conflicts: # deps/llhttp/README.md # deps/llhttp/include/llhttp.h # deps/llhttp/src/llhttp.c
cc @nodejs/http @nodejs/http2 Note that handling of h2 preamble has changed and llhttp now returns HPE_PAUSED_H2_UPGRADE error.