Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix typo in assert.md #38152

Closed
wants to merge 1 commit into from
Closed

doc: fix typo in assert.md #38152

wants to merge 1 commit into from

Conversation

arkerone
Copy link
Contributor

@arkerone arkerone commented Apr 8, 2021

I found a typo in assert documentation :

"asssert" -> "assert"

@arkerone
doc: fix typo in assert.md
b9cf4e7 
change "asssert" to "assert"
@nodejs-github-bot nodejs-github-bot added assert Issues and PRs related to the assert subsystem. doc Issues and PRs related to the documentations. labels Apr 8, 2021
@aduh95 aduh95 added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 8, 2021
@aduh95
Copy link
Contributor

aduh95 commented Apr 8, 2021

There's no reason to make this one wait the 48 hours to land. Collaborators, please 👍🏻 to fast-track

@jasnell
Copy link
Member

jasnell commented Apr 8, 2021

Landed in 093b527

@jasnell jasnell closed this Apr 8, 2021
jasnell pushed a commit that referenced this pull request Apr 8, 2021
@arkerone @jasnell
doc: fix typo in assert.md
093b527 
change "asssert" to "assert"

PR-URL: #38152
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@arkerone arkerone deleted the doc/fix-typo-assert branch April 8, 2021 16:03
@BethGriggs BethGriggs mentioned this pull request Apr 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaisinTen RaisinTen RaisinTen approved these changes

@aduh95 aduh95 aduh95 approved these changes

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
assert Issues and PRs related to the assert subsystem. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@arkerone @aduh95 @jasnell @cjihrig @RaisinTen @targos @nodejs-github-bot