typings: add types for internalBinding('fs') #38198
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
fs
targos
force-pushed
the
internal-fs-binding-typings
branch
from
81ed32d
to
3490e6d
Compare
targos
commented
Apr 11, 2021
|
@bmeck What do you think about |
targos
commented
Apr 11, 2021
jasnell
approved these changes
Apr 11, 2021
|
@targos seems fine to add that subsystem, I did not expect as many PRs/size of them to come in as are showing up so might want to do this quickly |
move to subdirectory
bmeck
approved these changes
Apr 12, 2021
|
@Trott is there something to update (documentation? tooling?) to add a new subsystem? |
|
@targos updating https://github.com/nodejs/core-validate-commit to have it in the subsystem rules is the main thing |
targos
added a commit
to targos/core-validate-commit
that referenced
this pull request
Apr 12, 2021
|
Created nodejs/core-validate-commit#92 |
Trott
approved these changes
Apr 13, 2021
targos
added a commit
to nodejs/core-validate-commit
that referenced
this pull request
Apr 13, 2021
targos
added a commit
that referenced
this pull request
Apr 14, 2021
PR-URL: #38198 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
|
Landed in cb2bdc6 |
BethGriggs
pushed a commit
that referenced
this pull request
Apr 15, 2021
PR-URL: #38198 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.