Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: patch V8 to 9.0.257.17 #38237

Closed
wants to merge 1 commit into from
Closed

deps: patch V8 to 9.0.257.17 #38237

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Apr 14, 2021

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Apr 14, 2021
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 14, 2021 •
edited by targos
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/37469/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/3919/

@targos targos mentioned this pull request Apr 14, 2021
Merged
@targos targos added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 14, 2021
@targos
Copy link
Member Author

targos commented Apr 14, 2021

Fast-track to ensure inclusion in Node.js 16.0.0 ?

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 14, 2021 •
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/37474/ 💚

@jasnell jasnell removed the needs-ci PRs that need a full CI run. label Apr 14, 2021
jasnell pushed a commit that referenced this pull request Apr 14, 2021
@targos @jasnell
deps: patch V8 to 9.0.257.17
8e80fc7 
Refs: v8/v8@9.0.257.16...9.0.257.17

PR-URL: #38237
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Apr 14, 2021

Landed in 8e80fc7

@jasnell jasnell closed this Apr 14, 2021
@targos targos deleted the v8-9.0.257.17 branch April 15, 2021 04:38
@AdamMajer
Copy link
Contributor

Should this be cherry-picked as a security related issue for other branches or only affects the case of untrusted-code?

BethGriggs pushed a commit that referenced this pull request Apr 15, 2021
@targos @BethGriggs
deps: patch V8 to 9.0.257.17
00aeff5 
Refs: v8/v8@9.0.257.16...9.0.257.17

PR-URL: #38237
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BethGriggs BethGriggs BethGriggs approved these changes

@richardlau richardlau richardlau approved these changes

@cjihrig cjihrig cjihrig approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@targos @nodejs-github-bot @jasnell @AdamMajer @Trott @cjihrig @richardlau @BethGriggs