doc: remove superfluous await from fsPromises.readdir example #38293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
aduh95
approved these changes
Apr 19, 2021
Trott
approved these changes
Apr 19, 2021
Trott
added
the
author ready
|
Collaboratros: 👍 to fast-track? |
benjamingr
approved these changes
Apr 19, 2021
The `await` operator in the example, iterating over the returned array of filenames is not necessary, since the returned array is either consisting of `string`s or of `fs.Dirent` objects, neither providing an asyncIterator. Refs: nodejs/help#3317 PR-URL: #38293 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
|
Landed in 36decec. Thanks for the contribution! 🎉 |
targos
pushed a commit
that referenced
this pull request
Sep 4, 2021
The `await` operator in the example, iterating over the returned array of filenames is not necessary, since the returned array is either consisting of `string`s or of `fs.Dirent` objects, neither providing an asyncIterator. Refs: nodejs/help#3317 PR-URL: #38293 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
awaitoperator in the example, iterating over the returned arrayof filenames is not necessary, since the returned array is either
consisting of
strings or offs.Direntobjects, neither providingan asyncIterator.
Refs: nodejs/help#3317