Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typings: add JSDoc typings for fs #38306

Closed
wants to merge 2 commits into from
Closed

typings: add JSDoc typings for fs #38306

wants to merge 2 commits into from

Conversation

VoltrexKeyva
Copy link
Member

Added JSDoc typings for the fs lib module.

@VoltrexKeyva
typings: add JSDoc typings for fs
9422ea4 
Added JSDoc typings for the `fs` lib module.
@nodejs-github-bot nodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Apr 20, 2021
mhdawson
mhdawson approved these changes Apr 22, 2021
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson
Copy link
Member

CI run https://ci.nodejs.org/job/node-test-pull-request/37624/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37624/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 25, 2021 •
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/37719/ 💚

jasnell pushed a commit that referenced this pull request Apr 27, 2021
@VoltrexKeyva @jasnell
typings: add JSDoc typings for fs
3240435 
Added JSDoc typings for the `fs` lib module.

PR-URL: #38306
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@jasnell
Copy link
Member

jasnell commented Apr 27, 2021

Landed in 3240435

@jasnell jasnell closed this Apr 27, 2021
@VoltrexKeyva VoltrexKeyva deleted the patch-2 branch April 27, 2021 22:08
@targos targos added the typings label Apr 28, 2021
targos pushed a commit that referenced this pull request Apr 29, 2021
@VoltrexKeyva @targos
typings: add JSDoc typings for fs
9a26513 
Added JSDoc typings for the `fs` lib module.

PR-URL: #38306
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@benjamingr benjamingr benjamingr approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. typings
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@VoltrexKeyva @mhdawson @nodejs-github-bot @jasnell @Trott @benjamingr @targos