test: fix test to allow quictls fork of OpenSSL 3 #38372
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The quictls fork of OpenSSL identifies itself with a `+quic` suffix in its version string. This was previously rejected by the version string check as the `+` was not an allowed character.
nodejs-github-bot
added
needs-ci
jasnell
approved these changes
Apr 23, 2021
addaleax
approved these changes
Apr 23, 2021
richardlau
added
the
author ready
cjihrig
approved these changes
Apr 24, 2021
danbev
pushed a commit
that referenced
this pull request
Apr 26, 2021
The quictls fork of OpenSSL identifies itself with a `+quic` suffix in its version string. This was previously rejected by the version string check as the `+` was not an allowed character. PR-URL: #38372 Refs: 7ac6265 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
Landed in dee3741. |
targos
pushed a commit
that referenced
this pull request
Apr 29, 2021
The quictls fork of OpenSSL identifies itself with a `+quic` suffix in its version string. This was previously rejected by the version string check as the `+` was not an allowed character. PR-URL: #38372 Refs: 7ac6265 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The quictls fork of OpenSSL identifies itself with a
+quicsuffixin its version string. This was previously rejected by the version
string check as the
+was not an allowed character.Refs: 7ac6265
Discovered while testing nodejs/build#2613.