Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debugger: cherry-pick remaining commits for node-inspect #38400

Merged
merged 3 commits into from
Apr 27, 2021
Merged

debugger: cherry-pick remaining commits for node-inspect #38400

merged 3 commits into from
Apr 27, 2021

Commits on Apr 27, 2021

  1. debugger: add usage example for --port 

    PR-URL: nodejs#38400
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @RafaelGSS @Trott
    RafaelGSS authored and Trott committed Apr 27, 2021
    Configuration menu
    Copy the full SHA
    302cc9e View commit details
    Browse the repository at this point in the history

  2. debugger: align message with Node.js standard 

    Node.js uses (or will use) _Ctrl+C_ with no spaces. To unify the
messages from inspect with other messages from the REPL and elsewhere,
make that change in node-inspect too.

PR-URL: nodejs#38400
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @Trott
    Trott committed Apr 27, 2021
    Configuration menu
    Copy the full SHA
    01e0e32 View commit details
    Browse the repository at this point in the history

  3. debugger: remove unused function argument 

    The `{colors: true}` removed here is ignored by the function it is being
sent to.

PR-URL: nodejs#38400
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @Trott
    Trott committed Apr 27, 2021
    Configuration menu
    Copy the full SHA
    751d215 View commit details
    Browse the repository at this point in the history