Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf_hooks: fix PerformanceObserver 'gc' crash #38414

Closed
wants to merge 1 commit into from
Closed

perf_hooks: fix PerformanceObserver 'gc' crash #38414

wants to merge 1 commit into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Apr 26, 2021

Signed-off-by: James M Snell jasnell@gmail.com
Fixes: #38412

@jasnell
perf_hooks: fix PerformanceObserver 'gc' crash
512def4 
Signed-off-by: James M Snell <jasnell@gmail.com>
Fixes: nodejs#38412
@github-actions github-actions bot added the needs-ci PRs that need a full CI run. label Apr 26, 2021
@jasnell jasnell mentioned this pull request Apr 26, 2021
Closed
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 26, 2021 •
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/37740/ 💚

@jasnell jasnell added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. perf_hooks Issues and PRs related to the implementation of the Performance Timing API. and removed needs-ci PRs that need a full CI run. labels Apr 26, 2021
@jasnell
Copy link
Member Author

jasnell commented Apr 27, 2021

CI is green and this has plenty of signoff. It shouldn't need to wait the full 48 hours to land. Please 👍🏻 to fast-track.

@jasnell jasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 27, 2021
@jasnell
Copy link
Member Author

jasnell commented Apr 27, 2021

Landed in ea01548

@jasnell jasnell closed this Apr 27, 2021
jasnell added a commit that referenced this pull request Apr 27, 2021
@jasnell
perf_hooks: fix PerformanceObserver 'gc' crash
ea01548 
Signed-off-by: James M Snell <jasnell@gmail.com>
Fixes: #38412

PR-URL: #38414
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
targos pushed a commit that referenced this pull request Apr 29, 2021
@jasnell @targos
perf_hooks: fix PerformanceObserver 'gc' crash
013fa59 
Signed-off-by: James M Snell <jasnell@gmail.com>
Fixes: #38412

PR-URL: #38414
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
@targos targos mentioned this pull request May 3, 2021
Merged
@rochdev rochdev mentioned this pull request Jul 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@Lxxyx Lxxyx Lxxyx approved these changes

@richardlau richardlau richardlau approved these changes

@targos targos targos approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. perf_hooks Issues and PRs related to the implementation of the Performance Timing API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

perf_hooks.PerformanceObserver.observe kills node.js 16.0.0 when registering same entryTypes twice
7 participants
@jasnell @nodejs-github-bot @addaleax @targos @richardlau @Lxxyx @aduh95