Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: document 'secureConnect' event limitation #38447

Closed
wants to merge 1 commit into from
Closed

doc: document 'secureConnect' event limitation #38447

wants to merge 1 commit into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Apr 28, 2021

Fixes: #10555
Signed-off-by: James M Snell jasnell@gmail.com
Refs: #10846

@jasnell
doc: document 'secureConnect' event limitation
e3131ee 
Fixes: nodejs#10555
Signed-off-by: James M Snell <jasnell@gmail.com>
Refs: nodejs#10846
@github-actions github-actions bot added doc Issues and PRs related to the documentations. tls Issues and PRs related to the tls subsystem. labels Apr 28, 2021
@jasnell jasnell added the review wanted PRs that need reviews. label Apr 30, 2021
@jasnell
Copy link
Member Author

jasnell commented Apr 30, 2021

@nodejs/crypto

targos pushed a commit that referenced this pull request May 2, 2021
@jasnell @targos
doc: document 'secureConnect' event limitation
99099f9 
Fixes: #10555
Signed-off-by: James M Snell <jasnell@gmail.com>
Refs: #10846

PR-URL: #38447
Reviewed-By: Alba Mendez <me@alba.sh>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
@targos
Copy link
Member

targos commented May 2, 2021

Landed in 99099f9

@targos targos closed this May 2, 2021
targos pushed a commit that referenced this pull request May 3, 2021
@jasnell @targos
doc: document 'secureConnect' event limitation
3b0480d 
Fixes: #10555
Signed-off-by: James M Snell <jasnell@gmail.com>
Refs: #10846

PR-URL: #38447
Reviewed-By: Alba Mendez <me@alba.sh>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
@targos targos mentioned this pull request May 3, 2021
Merged
targos pushed a commit that referenced this pull request May 30, 2021
@jasnell @targos
doc: document 'secureConnect' event limitation
6fa4834 
Fixes: #10555
Signed-off-by: James M Snell <jasnell@gmail.com>
Refs: #10846

PR-URL: #38447
Reviewed-By: Alba Mendez <me@alba.sh>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
targos pushed a commit that referenced this pull request Jun 5, 2021
@jasnell @targos
doc: document 'secureConnect' event limitation
d12acf9 
Fixes: #10555
Signed-off-by: James M Snell <jasnell@gmail.com>
Refs: #10846

PR-URL: #38447
Reviewed-By: Alba Mendez <me@alba.sh>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
targos pushed a commit that referenced this pull request Jun 5, 2021
@jasnell @targos
doc: document 'secureConnect' event limitation
21d836e 
Fixes: #10555
Signed-off-by: James M Snell <jasnell@gmail.com>
Refs: #10846

PR-URL: #38447
Reviewed-By: Alba Mendez <me@alba.sh>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
@targos targos mentioned this pull request Jun 6, 2021
Merged
targos pushed a commit that referenced this pull request Jun 11, 2021
@jasnell @targos
doc: document 'secureConnect' event limitation
4c54d81 
Fixes: #10555
Signed-off-by: James M Snell <jasnell@gmail.com>
Refs: #10846

PR-URL: #38447
Reviewed-By: Alba Mendez <me@alba.sh>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edsadr edsadr edsadr approved these changes

@mildsunrise mildsunrise mildsunrise approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. review wanted PRs that need reviews. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tls: secureConnect event will not be emitted if TLSSocket is created via constructor instead of tls.connect
4 participants
@jasnell @targos @mildsunrise @edsadr