node-api: faster threadsafe_function #38506
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
c++
|
Sorry, this is not yet ready for review. I've realized that the removal of |
Invoke threadsafe_function during the same tick and avoid marshalling costs between threads and/or churning event loop if either: 1. There's a queued call already 2. `Push()` is called while the main thread was running threadsafe_function
|
Now fixed. PTAL @addaleax |
indutny
force-pushed
the
feature/faster-threadsafe-function
branch
from
37b10a7
to
42ccd43
Compare
5 tasks
indutny
commented
May 2, 2021
addaleax
approved these changes
May 2, 2021
indutny
commented
May 2, 2021
| queue.push(data); | ||
| Send(); |
There was a problem hiding this comment.
I've swapped the order since uv_async_send() error is treated as a hard failure and it is more logical to push before the notification.
indutny
commented
May 2, 2021
| // `kMaxIterationCount` in `src/node_api.cc` | ||
| .then(() => testWithJSMarshaller({ | ||
| threadStarter: 'StartThreadNonblocking', | ||
| maxQueueSize: binding.ARRAY_LENGTH >>> 1, |
There was a problem hiding this comment.
Looks stupid, but there is an assert in the binding that the queue block at least once, and I didn't want to change .c code 😂
addaleax
approved these changes
May 2, 2021
|
/me sets a reminder to land this after 48 hours. |
Trott
approved these changes
May 3, 2021
jasnell
approved these changes
May 4, 2021
jasnell
added
author ready
indutny
added a commit
that referenced
this pull request
May 5, 2021
Invoke threadsafe_function during the same tick and avoid marshalling costs between threads and/or churning event loop if either: 1. There's a queued call already 2. `Push()` is called while the main thread was running threadsafe_function PR-URL: #38506 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
indutny
added a commit
to indutny/io.js
that referenced
this pull request
May 5, 2021
Invoke threadsafe_function during the same tick and avoid marshalling costs between threads and/or churning event loop if either: 1. There's a queued call already 2. `Push()` is called while the main thread was running threadsafe_function Backport-PR-URL: nodejs#38506
|
Opened a backport PR: #38543 . Let me know if I messed this up! |
indutny
added a commit
to indutny/io.js
that referenced
this pull request
May 5, 2021
Invoke threadsafe_function during the same tick and avoid marshalling costs between threads and/or churning event loop if either: 1. There's a queued call already 2. `Push()` is called while the main thread was running threadsafe_function PR-URL: nodejs#38506 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Here's a PR against v16.x-staging: #38547 |
indutny-signal
pushed a commit
to indutny/electron
that referenced
this pull request
May 5, 2021
indutny
added a commit
to indutny/electron
that referenced
this pull request
May 5, 2021
5 tasks
deepak1556
pushed a commit
to electron/electron
that referenced
this pull request
May 6, 2021
codebytere
pushed a commit
to electron/electron
that referenced
this pull request
May 6, 2021
MarshallOfSound
pushed a commit
to electron/electron
that referenced
this pull request
May 7, 2021
Backports: nodejs/node#38506 Co-authored-by: Fedor Indutny <fedor@indutny.com>
MarshallOfSound
pushed a commit
to electron/electron
that referenced
this pull request
May 7, 2021
Backports: nodejs/node#38506 Co-authored-by: Fedor Indutny <fedor@indutny.com>
|
We have a persistent failure in the node-addon-api testing which started around this time. nodejs/node-addon-api#994 |
targos
pushed a commit
that referenced
this pull request
May 17, 2021
Invoke threadsafe_function during the same tick and avoid marshalling costs between threads and/or churning event loop if either: 1. There's a queued call already 2. `Push()` is called while the main thread was running threadsafe_function PR-URL: #38506 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere
added a commit
to electron/electron
that referenced
this pull request
May 20, 2021
targos
pushed a commit
that referenced
this pull request
May 30, 2021
Invoke threadsafe_function during the same tick and avoid marshalling costs between threads and/or churning event loop if either: 1. There's a queued call already 2. `Push()` is called while the main thread was running threadsafe_function PR-URL: #38506 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere
added a commit
to electron/electron
that referenced
this pull request
May 31, 2021
codebytere
added a commit
to electron/electron
that referenced
this pull request
May 31, 2021
targos
pushed a commit
that referenced
this pull request
Jun 5, 2021
Invoke threadsafe_function during the same tick and avoid marshalling costs between threads and/or churning event loop if either: 1. There's a queued call already 2. `Push()` is called while the main thread was running threadsafe_function PR-URL: #38506 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jun 5, 2021
Invoke threadsafe_function during the same tick and avoid marshalling costs between threads and/or churning event loop if either: 1. There's a queued call already 2. `Push()` is called while the main thread was running threadsafe_function PR-URL: #38506 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere
added a commit
to electron/electron
that referenced
this pull request
Jun 8, 2021
codebytere
added a commit
to electron/electron
that referenced
this pull request
Jun 9, 2021
codebytere
added a commit
to electron/electron
that referenced
this pull request
Jun 10, 2021
targos
pushed a commit
that referenced
this pull request
Jun 11, 2021
Invoke threadsafe_function during the same tick and avoid marshalling costs between threads and/or churning event loop if either: 1. There's a queued call already 2. `Push()` is called while the main thread was running threadsafe_function PR-URL: #38506 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Invoke threadsafe_function during the same tick and avoid marshalling
costs between threads and/or churning event loop if either:
Push()is called while the main thread was runningthreadsafe_function