Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: patch V8 to 9.0.257.25 #38556

Closed
wants to merge 1 commit into from
Closed

deps: patch V8 to 9.0.257.25 #38556

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented May 5, 2021

@github-actions github-actions bot added needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels May 5, 2021
@targos targos added the fast-track PRs that do not need to wait for 48 hours to land. label May 5, 2021
@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2021

Fast-track has been requested by @targos. Please 👍 to approve.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37937/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37954/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37958/

@jasnell
Copy link
Member

jasnell commented May 7, 2021

Landed in 464535b

@jasnell jasnell closed this May 7, 2021
jasnell pushed a commit that referenced this pull request May 7, 2021
@targos @jasnell
deps: patch V8 to 9.0.257.25
464535b 
Refs: v8/v8@9.0.257.24...9.0.257.25

PR-URL: #38556
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos deleted the v8-9.0.257.25 branch May 7, 2021 17:33
targos added a commit that referenced this pull request May 17, 2021
@targos
deps: patch V8 to 9.0.257.25
ec2dbfb 
Refs: v8/v8@9.0.257.24...9.0.257.25

PR-URL: #38556
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request May 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@targos @nodejs-github-bot @jasnell @cjihrig @gengjiawen @richardlau