Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test,repl: fix tests when inspector is disabled #38564

Merged
merged 1 commit into from
May 9, 2021
Merged

test,repl: fix tests when inspector is disabled #38564

merged 1 commit into from
May 9, 2021

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented May 6, 2021

Fixes: #38558

@github-actions github-actions bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels May 6, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 6, 2021 •
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/37946/ 💚

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 7, 2021
@jasnell jasnell added fast-track PRs that do not need to wait for 48 hours to land. and removed needs-ci PRs that need a full CI run. labels May 7, 2021
@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2021

Fast-track has been requested by @jasnell. Please 👍 to approve.

@Trott
Copy link
Member

Trott commented May 8, 2021

I thought we had a no-inspector build in CI, but I guess we don't?

@aduh95 aduh95 removed the fast-track PRs that do not need to wait for 48 hours to land. label May 9, 2021
@aduh95
test,repl: fix tests when inspector is disabled
7c8a608 
Fixes: nodejs#38558

PR-URL: nodejs#38564
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@aduh95
Copy link
Contributor Author

aduh95 commented May 9, 2021

Landed in 7c8a608

@aduh95 aduh95 merged commit 7c8a608 into nodejs:master May 9, 2021
@aduh95 aduh95 deleted the fix-repl-test branch May 9, 2021 07:19
targos pushed a commit that referenced this pull request May 17, 2021
@aduh95 @targos
test,repl: fix tests when inspector is disabled
24472d9 
Fixes: #38558

PR-URL: #38564
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request May 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

>=node-16.0.0: failed test # 12 in parallel/test-repl-history-navigation
6 participants
@aduh95 @nodejs-github-bot @Trott @jasnell @addaleax @targos