Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove unused module from test #3870

Closed
wants to merge 1 commit into from
Closed

test: remove unused module from test #3870

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Nov 17, 2015

os is loaded but not used in test-child-process-spawnsync-input.js.
Remove it.

@Trott
test: remove unused module from test
9838c2f 
`os` is loaded but not used in `test-child-process-spawnsync-input.js`.
Remove it.
@Trott Trott added the test Issues and PRs related to the tests. label Nov 17, 2015
@Trott
Copy link
Member Author

Trott commented Nov 17, 2015

CI: https://ci.nodejs.org/job/node-test-pull-request/756/

@evanlucas
Copy link
Contributor

LGTM if CI is happy

@mscdex mscdex added the child_process Issues and PRs related to the child_process subsystem. label Nov 17, 2015
@Trott
Copy link
Member Author

Trott commented Nov 17, 2015

Usual smattering of unrelated failures on the usual suspect builds. Looks good otherwise.

@jasnell
Copy link
Member

jasnell commented Nov 17, 2015

LGTM

@jasnell jasnell mentioned this pull request Nov 17, 2015
Closed
@jasnell
Copy link
Member

jasnell commented Nov 17, 2015

this was actually resolved by landing #3871 (which included the same fix)

@jasnell jasnell closed this Nov 17, 2015
@Trott Trott deleted the rm-os branch January 13, 2022 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
child_process Issues and PRs related to the child_process subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Trott @evanlucas @jasnell @mscdex