Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: improve coverage of stream.Readable #38702

Closed
wants to merge 4 commits into from
Closed

test: improve coverage of stream.Readable #38702

wants to merge 4 commits into from

Conversation

pd4d10
Copy link
Contributor

@pd4d10 pd4d10 commented May 16, 2021

@pd4d10 @aduh95
Update test/parallel/test-stream-readable-read-size.js
2f9871a 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. stream Issues and PRs related to the stream subsystem. test Issues and PRs related to the tests. labels May 16, 2021
@Linkgoron
Copy link
Member

Linkgoron commented May 16, 2021 •
edited
Loading

I think that it would make sense to put this in test-streams-highwatermark.js

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@github-actions github-actions bot added the needs-ci PRs that need a full CI run. label May 16, 2021
Trott
Trott approved these changes May 16, 2021
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with suggestion or similar fix

@pd4d10 @Trott
Update test/parallel/test-streams-highwatermark.js
c41d857 
Co-authored-by: Rich Trott <rtrott@gmail.com>
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
mcollina
mcollina approved these changes May 18, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nodejs-github-bot

This comment has been minimized.

Sign in to view
waelsy123
waelsy123 approved these changes May 19, 2021
View reviewed changes
Copy link
Contributor

@waelsy123 waelsy123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 19, 2021 •
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/38202/ 💚

@jasnell
Copy link
Member

jasnell commented May 19, 2021

Landed in fc6e7e9

@jasnell jasnell closed this May 19, 2021
jasnell pushed a commit that referenced this pull request May 19, 2021
@pd4d10 @jasnell
test: improve coverage of stream.Readable
fc6e7e9 
PR-URL: #38702
Refs: https://coverage.nodejs.org/coverage-0996eb71edbd47d9/lib/internal/streams/readable.js.html#L401
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@pd4d10 pd4d10 deleted the test-stream-read-size branch May 19, 2021 16:27
danielleadams pushed a commit that referenced this pull request May 31, 2021
@pd4d10 @danielleadams
test: improve coverage of stream.Readable
929e8df 
PR-URL: #38702
Refs: https://coverage.nodejs.org/coverage-0996eb71edbd47d9/lib/internal/streams/readable.js.html#L401
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@danielleadams danielleadams mentioned this pull request May 31, 2021
Merged
targos pushed a commit that referenced this pull request Sep 4, 2021
@pd4d10 @targos
test: improve coverage of stream.Readable
f13a302 
PR-URL: #38702
Refs: https://coverage.nodejs.org/coverage-0996eb71edbd47d9/lib/internal/streams/readable.js.html#L401
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@targos targos mentioned this pull request Sep 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@waelsy123 waelsy123 waelsy123 approved these changes

@watilde watilde watilde approved these changes

@lpinca lpinca lpinca approved these changes

@benjamingr benjamingr benjamingr approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. stream Issues and PRs related to the stream subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.