Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: allow empty string as first stream of pipeline #38723

Closed
wants to merge 2 commits into from
Closed

stream: allow empty string as first stream of pipeline #38723

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e704e99
stream: allow empty string as source of pipeline
Ayase-252 May 18, 2021
a0fb263
fixup!: simplify test condition
Ayase-252 May 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/internal/streams/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ function isStream(obj) {
}

function isIterable(obj, isAsync) {
if (!obj) return false;
if (!obj && typeof obj !== 'string') return false;
Ayase-252 marked this conversation as resolved.
Show resolved Hide resolved
if (isAsync === true) return typeof obj[SymbolAsyncIterator] === 'function';
if (isAsync === false) return typeof obj[SymbolIterator] === 'function';
return typeof obj[SymbolAsyncIterator] === 'function' ||
Expand Down
18 changes: 18 additions & 0 deletions test/parallel/test-stream-pipeline-with-empty-string.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
'use strict';

const common = require('../common');
const {
pipeline,
PassThrough
} = require('stream');


async function runTest() {
await pipeline(
'',
new PassThrough({ objectMode: true }),
common.mustCall(() => { })
);
}

runTest().then(common.mustCall(() => {}));