Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: support fs_event_wrap in the snapshot and load more modules eagerly #38737

Closed
wants to merge 3 commits into from
Closed

lib: support fs_event_wrap in the snapshot and load more modules eagerly #38737

wants to merge 3 commits into from

Conversation

joyeecheung
Copy link
Member

@joyeecheung joyeecheung commented May 19, 2021 •
edited
Loading

Now that we support more modules in the snapshot, it's no longer necessary to lazy load them for speeding up startup.

Refs: #35711

@joyeecheung
src: support fs_event_wrap binding in the snapshot
d4b4575
@joyeecheung
lib: load internal/fs/watchers and internal/fs/read_file_context early
c4f0832 
So that they are included in the builtin snapshot
@joyeecheung
lib: remove unnecessary lazy loads
02df983 
Now that more modules are included in the snapshot, it's not
necessary to lazy load them anymore
@github-actions github-actions bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels May 19, 2021
@joyeecheung joyeecheung changed the title lib: support fs_event_wrap in the snapshot and eagerly-load more modules lib: support fs_event_wrap in the snapshot and load more modules eagerly May 19, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/38213/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/38330/

joyeecheung added a commit that referenced this pull request May 27, 2021
@joyeecheung
src: support fs_event_wrap binding in the snapshot
39b0f4f 
PR-URL: #38737
Refs: #35711
Reviewed-By: Anna Henningsen <anna@addaleax.net>
joyeecheung added a commit that referenced this pull request May 27, 2021
@joyeecheung
lib: load internal/fs/watchers and internal/fs/read_file_context early
9e42b4d 
So that they are included in the builtin snapshot

PR-URL: #38737
Refs: #35711
Reviewed-By: Anna Henningsen <anna@addaleax.net>
joyeecheung added a commit that referenced this pull request May 27, 2021
@joyeecheung
lib: remove unnecessary lazy loads
a4ea9fc 
Now that more modules are included in the snapshot, it's not
necessary to lazy load them anymore

PR-URL: #38737
Refs: #35711
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@joyeecheung
Copy link
Member Author

Landed in b6471c9...a4ea9fc

danielleadams pushed a commit that referenced this pull request May 31, 2021
@joyeecheung @danielleadams
src: support fs_event_wrap binding in the snapshot
a1b0e64 
PR-URL: #38737
Refs: #35711
Reviewed-By: Anna Henningsen <anna@addaleax.net>
danielleadams pushed a commit that referenced this pull request May 31, 2021
@joyeecheung @danielleadams
lib: load internal/fs/watchers and internal/fs/read_file_context early
5d9442a 
So that they are included in the builtin snapshot

PR-URL: #38737
Refs: #35711
Reviewed-By: Anna Henningsen <anna@addaleax.net>
danielleadams pushed a commit that referenced this pull request May 31, 2021
@joyeecheung @danielleadams
lib: remove unnecessary lazy loads
7d3a8cb 
Now that more modules are included in the snapshot, it's not
necessary to lazy load them anymore

PR-URL: #38737
Refs: #35711
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@danielleadams danielleadams mentioned this pull request May 31, 2021
Merged
@richardlau
Copy link
Member

Blocked on #32984.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@joyeecheung @nodejs-github-bot @richardlau @addaleax @VoltrexKeyva