Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

url: exit early when : delimiter is seen in hostname #38742

Closed
wants to merge 1 commit into from
Closed

url: exit early when : delimiter is seen in hostname #38742

wants to merge 1 commit into from

Conversation

TimothyGu
Copy link
Member

This aligns with an upstream spec change.

Fixes: #38710

@github-actions github-actions bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels May 20, 2021
@TimothyGu TimothyGu added the whatwg-url Issues and PRs related to the WHATWG URL implementation. label May 20, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 20, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@TimothyGu
url: exit early when : delimiter is seen in hostname
f93c97c 
This aligns with an upstream spec change.

Fixes: nodejs#38710
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/38266/

@TimothyGu
Copy link
Member Author

Updated the WPT status file. Should hopefully work on without-intl builds now.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/38272/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/38284/

TimothyGu added a commit that referenced this pull request May 23, 2021
@TimothyGu
url: exit early when : delimiter is seen in hostname
bf06daa 
This aligns with an upstream spec change.

PR-URL: #38742
Fixes: #38710
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@TimothyGu
Copy link
Member Author

Landed in bf06daa.

@TimothyGu TimothyGu closed this May 23, 2021
@TimothyGu TimothyGu deleted the colon-noop branch May 23, 2021 00:47
danielleadams pushed a commit that referenced this pull request May 31, 2021
@TimothyGu @danielleadams
url: exit early when : delimiter is seen in hostname
7773d58 
This aligns with an upstream spec change.

PR-URL: #38742
Fixes: #38710
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadams danielleadams mentioned this pull request May 31, 2021
Merged
@richardlau
Copy link
Member

Does not land cleanly on v14.x-staging.

@targos
Copy link
Member

targos commented Jul 16, 2021

v14.x is missing a lot of URL and WPT commits.

This was referenced Aug 21, 2021
Closed
Merged
@RaisinTen
Copy link
Contributor

Reason behind marking this as dont-land-on-v14.x: #37877 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaisinTen RaisinTen RaisinTen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. whatwg-url Issues and PRs related to the WHATWG URL implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WHATWG URL spec change: Make hostname setter no-op if a port is given
7 participants
@TimothyGu @nodejs-github-bot @richardlau @targos @RaisinTen @jasnell @cjihrig