benchmark: fix http elapsed time #38743
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since commit 4e9ad20, elapsed time is expected to be a BigInt instead of an array. Refs: nodejs#38369
github-actions
bot
added
benchmark
benjamingr
approved these changes
May 20, 2021
aduh95
added
the
author ready
RaisinTen
approved these changes
May 20, 2021
jasnell
approved these changes
May 20, 2021
This comment has been minimized.
This comment has been minimized.
lpinca
approved these changes
May 20, 2021
|
Fast-track has been requested by @jasnell. Please 👍 to approve. |
Lxxyx
approved these changes
May 23, 2021
Lxxyx
pushed a commit
to Lxxyx/node
that referenced
this pull request
May 23, 2021
Since commit 4e9ad20, elapsed time is expected to be a BigInt instead of an array. Refs: nodejs#38369 PR-URL: nodejs#38743 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
|
Landed in ba84524 |
danielleadams
pushed a commit
that referenced
this pull request
May 31, 2021
Since commit 4e9ad20, elapsed time is expected to be a BigInt instead of an array. Refs: #38369 PR-URL: #38743 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Merged
richardlau
pushed a commit
that referenced
this pull request
Jul 16, 2021
Since commit 4e9ad20, elapsed time is expected to be a BigInt instead of an array. Refs: #38369 PR-URL: #38743 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
richardlau
pushed a commit
that referenced
this pull request
Jul 19, 2021
Since commit 4e9ad20, elapsed time is expected to be a BigInt instead of an array. Refs: #38369 PR-URL: #38743 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
richardlau
pushed a commit
that referenced
this pull request
Jul 20, 2021
Since commit 4e9ad20, elapsed time is expected to be a BigInt instead of an array. Refs: #38369 PR-URL: #38743 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Merged
foxxyz
pushed a commit
to foxxyz/node
that referenced
this pull request
Oct 18, 2021
Since commit 4e9ad20, elapsed time is expected to be a BigInt instead of an array. Refs: nodejs#38369 PR-URL: nodejs#38743 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since commit 4e9ad20, elapsed time is expected to be a BigInt instead of an array. This make the R script fails such as in https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1026/.
Refs: #38369