src: set SSL_OP_ALLOW_CLIENT_RENEGOTIATION #38753
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit sets SSL_OP_ALLOW_CLIENT_RENEGOTIATION for OpenSSL 3.0 as this option is not set by default as it was in previous versions. Without this option set there are a few tests that fail when linked against OpenSSl 3.0.0-alpha-17, for example test-https-client-renegotiation-limit.js. I'm not sure we should be setting this for OpenSSL 3.0 or not, but I'll take a closer look at the implications but if nothing else this would allow for us to update to alpha-17 in the mean time.
github-actions
bot
added
c++
addaleax
approved these changes
May 22, 2021
jasnell
approved these changes
May 24, 2021
|
I will say that for http2 and quic, having renegotiation disabled by default does make the most sense... so we might want to revisit this |
danbev
added a commit
to danbev/build
that referenced
this pull request
Jul 16, 2021
This commit updates the version of quictls/openssl to 3.0.0-beta1. This change will cause a test failure so it need to be coordinated with nodejs/node#38753.
danbev
added a commit
to danbev/build
that referenced
this pull request
Jul 16, 2021
This commit updates the version of quictls/openssl to 3.0.0-beta1. This change will cause a test failure so it needs to be coordinated with nodejs/node#38753.
richardlau
pushed a commit
to nodejs/build
that referenced
this pull request
Jul 16, 2021
This commit updates the version of quictls/openssl to 3.0.0-beta1. This change will cause a test failure so it needs to be coordinated with nodejs/node#38753.
|
I need to restart the containers after they rebuild (in progress) and then I'll start CI for this. |
Thanks! |
richardlau
approved these changes
Jul 16, 2021
richardlau
added
the
author ready
|
Re-run of failing node-test-commit-osx-arm ✔️ |
richardlau
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
|
Landed in 1efa8fe...44e3822 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Jul 16, 2021
This commit sets SSL_OP_ALLOW_CLIENT_RENEGOTIATION for OpenSSL 3.0 as this option is not set by default as it was in previous versions. Without this option set there are a few tests that fail when linked against OpenSSl 3.0.0-alpha-17, for example test-https-client-renegotiation-limit.js. I'm not sure we should be setting this for OpenSSL 3.0 or not, but I'll take a closer look at the implications but if nothing else this would allow for us to update to alpha-17 in the mean time. PR-URL: #38753 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
targos
pushed a commit
that referenced
this pull request
Jul 17, 2021
This commit sets SSL_OP_ALLOW_CLIENT_RENEGOTIATION for OpenSSL 3.0 as this option is not set by default as it was in previous versions. Without this option set there are a few tests that fail when linked against OpenSSl 3.0.0-alpha-17, for example test-https-client-renegotiation-limit.js. I'm not sure we should be setting this for OpenSSL 3.0 or not, but I'll take a closer look at the implications but if nothing else this would allow for us to update to alpha-17 in the mean time. PR-URL: #38753 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Jul 29, 2021
This commit sets SSL_OP_ALLOW_CLIENT_RENEGOTIATION for OpenSSL 3.0 as this option is not set by default as it was in previous versions. Without this option set there are a few tests that fail when linked against OpenSSl 3.0.0-alpha-17, for example test-https-client-renegotiation-limit.js. I'm not sure we should be setting this for OpenSSL 3.0 or not, but I'll take a closer look at the implications but if nothing else this would allow for us to update to alpha-17 in the mean time. PR-URL: #38753 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit sets SSL_OP_ALLOW_CLIENT_RENEGOTIATION for OpenSSL 3.0 as
this option is not set by default as it was in previous versions.
Without this option set there are a few tests that fail when linked
against OpenSSl 3.0.0-alpha-17, for example test-https-client-renegotiation-limit.js.
I'm not sure we should be setting this for OpenSSL 3.0 or not, but I'll take
a closer look at the implications. If nothing else this would allow
for us to update to alpha-17 in the mean time.