Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: improve coverage for question in readline #38799

Closed
wants to merge 1 commit into from
Closed

test: improve coverage for question in readline #38799

wants to merge 1 commit into from

Conversation

Ayase-252
Copy link
Member

Improve test coverage for Interface.question.

It indicates that only the first callback is effective when question is calling multiple times.

Ref: https://coverage.nodejs.org/coverage-dc43066ee9a37655/lib/readline.js.html#L443

@github-actions github-actions bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels May 24, 2021
@Lxxyx Lxxyx added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels May 25, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 25, 2021 •
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/38327/ 💚

@jasnell jasnell added the fast-track PRs that do not need to wait for 48 hours to land. label May 25, 2021
@github-actions
Copy link
Contributor

Fast-track has been requested by @jasnell. Please 👍 to approve.

Lxxyx pushed a commit that referenced this pull request May 26, 2021
@Ayase-252 @Lxxyx
test: improve coverage for question in readline
ccde7fc 
PR-URL: #38799
Refs: https://coverage.nodejs.org/coverage-dc43066ee9a37655/lib/readline.js.html#L443
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Lxxyx
Copy link
Member

Lxxyx commented May 26, 2021

Landed in ccde7fc

@Lxxyx Lxxyx closed this May 26, 2021
@Ayase-252 Ayase-252 deleted the test/improve-readline-question branch May 26, 2021 14:11
danielleadams pushed a commit that referenced this pull request May 31, 2021
@Ayase-252 @danielleadams
test: improve coverage for question in readline
1f5baaa 
PR-URL: #38799
Refs: https://coverage.nodejs.org/coverage-dc43066ee9a37655/lib/readline.js.html#L443
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadams danielleadams mentioned this pull request May 31, 2021
Merged
richardlau pushed a commit that referenced this pull request Jul 16, 2021
@Ayase-252 @richardlau
test: improve coverage for question in readline
062b4d8 
PR-URL: #38799
Refs: https://coverage.nodejs.org/coverage-dc43066ee9a37655/lib/readline.js.html#L443
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
richardlau pushed a commit that referenced this pull request Jul 19, 2021
@Ayase-252 @richardlau
test: improve coverage for question in readline
f870a80 
PR-URL: #38799
Refs: https://coverage.nodejs.org/coverage-dc43066ee9a37655/lib/readline.js.html#L443
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
richardlau pushed a commit that referenced this pull request Jul 20, 2021
@Ayase-252 @richardlau
test: improve coverage for question in readline
504bfd7 
PR-URL: #38799
Refs: https://coverage.nodejs.org/coverage-dc43066ee9a37655/lib/readline.js.html#L443
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@richardlau richardlau mentioned this pull request Jul 20, 2021
Merged
foxxyz pushed a commit to foxxyz/node that referenced this pull request Oct 18, 2021
@Ayase-252 @foxxyz
test: improve coverage for question in readline
f46e785 
PR-URL: nodejs#38799
Refs: https://coverage.nodejs.org/coverage-dc43066ee9a37655/lib/readline.js.html#L443
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@Lxxyx Lxxyx Lxxyx approved these changes

@antsmartian antsmartian antsmartian approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Ayase-252 @nodejs-github-bot @Lxxyx @jasnell @antsmartian @aduh95