Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove unnecessary --pending-deprecation flag #38819

Merged
merged 1 commit into from
Jun 1, 2021
Merged

test: remove unnecessary --pending-deprecation flag #38819

merged 1 commit into from
Jun 1, 2021

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented May 26, 2021

Those have been migrated to runtime deprecation in v16.0.0.

@github-actions github-actions bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels May 26, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/38336/

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 26, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/38342/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/38429/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/38436/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/38438/

@aduh95
test: remove unnecessary --pending-deprecation flag
26bf4f3 
PR-URL: nodejs#38819
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@aduh95 aduh95 force-pushed the esm-exports-not-pending-deprecations branch from 7212173 to 26bf4f3 Compare June 1, 2021 22:17
@aduh95
Copy link
Contributor Author

aduh95 commented Jun 1, 2021

Landed in 26bf4f3

@aduh95 aduh95 merged commit 26bf4f3 into nodejs:master Jun 1, 2021
@aduh95 aduh95 deleted the esm-exports-not-pending-deprecations branch June 1, 2021 22:17
danielleadams pushed a commit that referenced this pull request Jun 2, 2021
@aduh95 @danielleadams
test: remove unnecessary --pending-deprecation flag
48ebebd 
PR-URL: #38819
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadams danielleadams mentioned this pull request Jun 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bl-ue bl-ue bl-ue approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@aduh95 @nodejs-github-bot @jasnell @Trott @lpinca @RaisinTen @bl-ue @richardlau