Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: include url in bootstrap snapshot and remove unnecessary lazy-loads #38826

Closed
wants to merge 1 commit into from
Closed

lib: include url in bootstrap snapshot and remove unnecessary lazy-loads #38826

wants to merge 1 commit into from

Conversation

joyeecheung
Copy link
Member

@joyeecheung joyeecheung commented May 27, 2021 •
edited
Loading

Refs: #35711

@github-actions github-actions bot added needs-ci PRs that need a full CI run. url Issues and PRs related to the legacy built-in url module. labels May 27, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/38356/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/38420/

@joyeecheung
Copy link
Member Author

It seems some tests fail with this, some tmp files weren't properly cleaned up after the test finished.

Can't clean tmpdir: /home/iojs/tmp/.tmp.261
Files blocking: [ '.nfs00000000019201330000031d' ]
Note: ".nfs*" might be files that were open and unlinked but not closed.
See http://nfs.sourceforge.net/#faq_d2 for details.

/home/iojs/build/workspace/node-test-binary-arm/test/common/tmpdir.js:55
    throw e;
    ^

Error: ENOTEMPTY: directory not empty, rmdir '/home/iojs/tmp/.tmp.261'
    at Object.rmdirSync (node:fs:1157:10)
    at _rmdirSync (node:internal/fs/rimraf:260:21)
    at rimrafSync (node:internal/fs/rimraf:193:7)
    at Object.rmSync (node:fs:1204:10)
    at rmSync (/home/iojs/build/workspace/node-test-binary-arm/test/common/tmpdir.js:9:6)
    at process.onexit (/home/iojs/build/workspace/node-test-binary-arm/test/common/tmpdir.js:40:5)
    at process.emit (node:events:406:35) {
  errno: -39,
  syscall: 'rmdir',
  code: 'ENOTEMPTY',
  path: '/home/iojs/tmp/.tmp.261'
}

I can't see why this PR would result in a difference, is it a test util bug? @nodejs/testing

@joyeecheung joyeecheung mentioned this pull request Jun 1, 2021
Closed
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/38427/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/38440/

@joyeecheung joyeecheung removed the needs-ci PRs that need a full CI run. label Jun 2, 2021
joyeecheung added a commit that referenced this pull request Jun 2, 2021
@joyeecheung
lib: include url in bootstrap snapshot and remove unnecessary lazy-loads
2bb0c20 
PR-URL: #38826
Refs: #35711
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
@joyeecheung
Copy link
Member Author

Landed in 2bb0c20

@joyeecheung joyeecheung closed this Jun 2, 2021
danielleadams pushed a commit that referenced this pull request Jun 2, 2021
@joyeecheung @danielleadams
lib: include url in bootstrap snapshot and remove unnecessary lazy-loads
4884991 
PR-URL: #38826
Refs: #35711
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
@danielleadams danielleadams mentioned this pull request Jun 2, 2021
Merged
@richardlau
Copy link
Member

This doesn't land cleanly on v14.x-staging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Apakottur Apakottur Apakottur approved these changes

@XadillaX XadillaX XadillaX approved these changes

@targos targos targos approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
url Issues and PRs related to the legacy built-in url module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@joyeecheung @nodejs-github-bot @richardlau @jasnell @targos @XadillaX @Apakottur