-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #38839
Update README.md #38839
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but would prefer Long Term Support
(see comment).
Use "Long Term Support" rather than "long term support". Refs: nodejs#38839 (comment)
Use "Long Term Support" rather than "Long-term support". Refs: nodejs#38839 (comment)
Use "Long Term Support" rather than "Long-term Support". Refs: nodejs#38839 (comment)
@Trott I wanted to comment under your post, but I guess I can't because it was also an approval, I'm new here and am still learning. I agree that we should standardize on "Long Term Support", it's the most common way used by Microsoft and other various companies across the top pages of Google whether you search for "Long-Term Support" or "Long Term Support". @bl-ue Thank you for raising the hyphen issue on top of the capitalization issue that I raised, that was the goal anyway to make the documentation more formal and proper. |
@nodejs/documentation |
Fast-track has been requested by @Trott. Please 👍 to approve. |
"Long-Term Support" should have a capital "T" according to most style guides if we're making it a proper noun as we are here. It's obviously not super important in the grand scope of the project, but it makes things appear more formal and correct. PR-URL: nodejs#38839 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Landed in 16ae378. Thanks for the contribution! 🎉 |
Use "Long Term Support" rather than "long term support". Refs: nodejs#38839 (comment)
Use "Long Term Support" rather than "Long-term support". Refs: nodejs#38839 (comment)
Use "Long Term Support" rather than "long term support". Refs: nodejs#38839 (comment) PR-URL: nodejs#38841 Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Use "Long Term Support" rather than "Long-term support". Refs: nodejs#38839 (comment) PR-URL: nodejs#38841 Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
"Long-Term Support" should have a capital "T" according to most style guides if we're making it a proper noun as we are here. It's obviously not super important in the grand scope of the project, but it makes things appear more formal and correct. PR-URL: #38839 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Use "Long Term Support" rather than "long term support". Refs: #38839 (comment) PR-URL: #38841 Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Use "Long Term Support" rather than "Long-term support". Refs: #38839 (comment) PR-URL: #38841 Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
"Long-Term Support" should have a capital "T" according to most style guides if we're making it a proper noun as we are here. It's obviously not super important in the grand scope of the project, but it makes things appear more formal and correct. PR-URL: #38839 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Use "Long Term Support" rather than "long term support". Refs: #38839 (comment) PR-URL: #38841 Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Use "Long Term Support" rather than "Long-term support". Refs: #38839 (comment) PR-URL: #38841 Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
"Long-Term Support" should have a capital "T" according to most style guides if we're making it a proper noun as we are here. It's obviously not super important in the grand scope of the project, but it makes things appear more formal and correct. PR-URL: #38839 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Use "Long Term Support" rather than "long term support". Refs: #38839 (comment) PR-URL: #38841 Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Use "Long Term Support" rather than "Long-term support". Refs: #38839 (comment) PR-URL: #38841 Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
"Long-Term Support" should have a capital "T" according to most style guides if we're making it a proper noun as we are here. It's obviously not super important in the grand scope of the project, but it makes things appear more formal and correct. PR-URL: #38839 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Use "Long Term Support" rather than "long term support". Refs: #38839 (comment) PR-URL: #38841 Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Use "Long Term Support" rather than "Long-term support". Refs: #38839 (comment) PR-URL: #38841 Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
"Long-Term Support" should have a capital "T" according to most style guides if we're making it a proper noun as we are here. It's obviously not super important in the grand scope of the project, but it makes things appear more formal and correct. PR-URL: nodejs#38839 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Use "Long Term Support" rather than "long term support". Refs: nodejs#38839 (comment) PR-URL: nodejs#38841 Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Use "Long Term Support" rather than "Long-term support". Refs: nodejs#38839 (comment) PR-URL: nodejs#38841 Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
"Long-Term Support" should have a capital "T" according to most style guides if we're making it a proper noun as we are here. It's obviously not super important in the grand scope of the project, but it makes things appear more formal and correct.