Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix name of variable in inspector-cli test #38869

Closed
wants to merge 1 commit into from
Closed

test: fix name of variable in inspector-cli test #38869

wants to merge 1 commit into from

Conversation

tniessen
Copy link
Member

This changes the spelling of the name of the local variable.

@github-actions github-actions bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels May 31, 2021
@bl-ue
Copy link
Contributor

bl-ue commented May 31, 2021 •
edited
Loading

🙂 I'll add this to codespell.

Edit: It's already there. I'll run codespell on the tests after this PR and PR the changes, if you don't mind.

@lpinca lpinca added the fast-track PRs that do not need to wait for 48 hours to land. label May 31, 2021
@github-actions
Copy link
Contributor

Fast-track has been requested by @lpinca. Please 👍 to approve.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/38403/

@Lxxyx Lxxyx added request-ci Add this label to start a Jenkins CI on a PR. and removed needs-ci PRs that need a full CI run. labels Jun 11, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 11, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/38579/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/38586/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/38638/

@bl-ue
Copy link
Contributor

bl-ue commented Jun 15, 2021

This should really be landed. Open for over two weeks, 5 approvals, fixes a tiny typo, and fast-track requested for over two weeks. ?? @RaisinTen?

@RaisinTen
Copy link
Contributor

@bl-ue I'm sorry but build-windows and coverage-windows GitHub Actions CI are failing currently. So I don't think we can land this PR until we have a passing GitHub Actions CI because of this:

node/doc/guides/collaborator-guide.md

Line 207 in 58bd046

A passing (green) GitHub Actions CI result is required. A passing (green or

@bl-ue
Copy link
Contributor

bl-ue commented Jun 15, 2021

I wonder if they can just be re-run. They look like possible flakes to me (tho I'm not that familiar with the node checks, admittedly).

@RaisinTen
Copy link
Contributor

I tried restarting the failed runs but they still fail. The issue has already been reported here: #39038

@tniessen
Copy link
Member Author

I think the reason is that GitHub actions doesn't rebase automatically (unlike Jenkins).

@RaisinTen
Copy link
Contributor

I think the reason is that GitHub actions doesn't rebase automatically (unlike Jenkins).

@tniessen It was happening because https://www.nasm.us/ was down. Now it is up, so the workflows should run as intended now.

@tniessen tniessen added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 16, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 16, 2021
@github-actions
Copy link
Contributor

Landed in 5b5a9eb...e7d5f0a

@github-actions github-actions bot closed this Jun 16, 2021
nodejs-github-bot pushed a commit that referenced this pull request Jun 16, 2021
@tniessen @nodejs-github-bot
test: fix name of variable in inspector-cli test
e7d5f0a 
PR-URL: #38869
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Jun 21, 2021
@tniessen @danielleadams
test: fix name of variable in inspector-cli test
5e9175f 
PR-URL: #38869
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadams danielleadams mentioned this pull request Jun 21, 2021
Merged
richardlau pushed a commit that referenced this pull request Jul 19, 2021
@tniessen @richardlau
test: fix name of variable in inspector-cli test
afeaf20 
PR-URL: #38869
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
richardlau pushed a commit that referenced this pull request Jul 20, 2021
@tniessen @richardlau
test: fix name of variable in inspector-cli test
6f1862e 
PR-URL: #38869
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@richardlau richardlau mentioned this pull request Jul 20, 2021
Merged
@tniessen tniessen deleted the fourty branch October 7, 2021 16:49
foxxyz pushed a commit to foxxyz/node that referenced this pull request Oct 18, 2021
@tniessen @foxxyz
test: fix name of variable in inspector-cli test
a337c07 
PR-URL: nodejs#38869
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bl-ue bl-ue bl-ue approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@tniessen @bl-ue @nodejs-github-bot @RaisinTen @jasnell @Trott @lpinca @cjihrig @Lxxyx