Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: make InitializeOncePerProcess more flexible #38888

Closed
wants to merge 1 commit into from
Closed

src: make InitializeOncePerProcess more flexible #38888

wants to merge 1 commit into from

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Jun 1, 2021 •
edited
Loading

This PR adds customizability to InitializeOncePerProcess by adding an overload with a third parameter containing flags which specify which aspects of InitializeOncePerProcess to run.

@codebytere codebytere added the embedding Issues and PRs related to embedding Node.js in another project. label Jun 1, 2021
@github-actions github-actions bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Jun 1, 2021
addaleax
addaleax requested changes Jun 1, 2021
View reviewed changes
src/node.cc Outdated Show resolved Hide resolved
@codebytere codebytere changed the title src: add NODE_USE_V8_PLATFORM in InitializeOncePerProcess src: make InitializeOncePerProcess more flexible Jun 3, 2021
@codebytere codebytere added the semver-minor PRs that contain new features and should be released in the next minor version. label Jun 3, 2021
@codebytere codebytere requested a review from addaleax June 3, 2021 10:46
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/38472/

@codebytere codebytere removed the needs-ci PRs that need a full CI run. label Jun 3, 2021
addaleax
addaleax approved these changes Jun 3, 2021
View reviewed changes
src/node.cc Outdated Show resolved Hide resolved
src/node.h Outdated Show resolved Hide resolved
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/38489/

@codebytere
Copy link
Member Author

codebytere commented Jun 7, 2021 •
edited
Loading

Landed in d8d1d96

@codebytere codebytere closed this Jun 7, 2021
codebytere added a commit that referenced this pull request Jun 7, 2021
@codebytere
src: make InitializeOncePerProcess more flexible
d8d1d96 
PR-URL: #38888
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@codebytere codebytere deleted the wrap-v8-platform branch June 7, 2021 08:41
targos pushed a commit that referenced this pull request Jun 11, 2021
@codebytere @targos
src: make InitializeOncePerProcess more flexible
06afb8d 
PR-URL: #38888
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadams danielleadams mentioned this pull request Jun 14, 2021
Merged
codebytere added a commit to electron/electron that referenced this pull request Jun 24, 2021
@codebytere
src: make InitializeOncePerProcess more flexible
59ba4a5 
nodejs/node#38888
@codebytere codebytere mentioned this pull request Jun 24, 2021
Closed
codebytere added a commit to electron/electron that referenced this pull request Jun 24, 2021
@codebytere
src: make InitializeOncePerProcess more flexible
1199163 
nodejs/node#38888
codebytere added a commit to electron/electron that referenced this pull request Jun 24, 2021
@codebytere
src: make InitializeOncePerProcess more flexible
2bd8c68 
nodejs/node#38888
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@bl-ue bl-ue bl-ue approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. embedding Issues and PRs related to embedding Node.js in another project. semver-minor PRs that contain new features and should be released in the next minor version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@codebytere @nodejs-github-bot @jasnell @addaleax @joyeecheung @bl-ue @targos