Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: correct Xcode spelling in .gitignore #38895

Closed
wants to merge 1 commit into from
Closed

build: correct Xcode spelling in .gitignore #38895

wants to merge 1 commit into from

Conversation

bl-ue
Copy link
Contributor

@bl-ue bl-ue commented Jun 1, 2021

No description provided.

@github-actions github-actions bot added the meta Issues and PRs related to the general management of the project. label Jun 1, 2021
@bl-ue
Copy link
Contributor Author

bl-ue commented Jun 1, 2021

GHA added the meta label — @targos would it be better if I changed the subsystem in the commit message / PR title to meta?

@jasnell
Copy link
Member

jasnell commented Jun 7, 2021

Landed in 7727dd5

@jasnell jasnell closed this Jun 7, 2021
jasnell pushed a commit that referenced this pull request Jun 7, 2021
@bl-ue @jasnell
build: correct Xcode spelling in .gitignore
7727dd5 
PR-URL: #38895
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@bl-ue bl-ue deleted the xcode-spelling branch June 7, 2021 14:51
targos pushed a commit that referenced this pull request Jun 11, 2021
@bl-ue @targos
build: correct Xcode spelling in .gitignore
651c58b 
PR-URL: #38895
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadams danielleadams mentioned this pull request Jun 14, 2021
Merged
richardlau pushed a commit that referenced this pull request Jul 16, 2021
@bl-ue @richardlau
build: correct Xcode spelling in .gitignore
54195a3 
PR-URL: #38895
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
richardlau pushed a commit that referenced this pull request Jul 19, 2021
@bl-ue @richardlau
build: correct Xcode spelling in .gitignore
3bde74f 
PR-URL: #38895
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
richardlau pushed a commit that referenced this pull request Jul 20, 2021
@bl-ue @richardlau
build: correct Xcode spelling in .gitignore
49a0006 
PR-URL: #38895
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@richardlau richardlau mentioned this pull request Jul 20, 2021
Merged
foxxyz pushed a commit to foxxyz/node that referenced this pull request Oct 18, 2021
@bl-ue @foxxyz
build: correct Xcode spelling in .gitignore
4f99ccf 
PR-URL: nodejs#38895
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaisinTen RaisinTen RaisinTen approved these changes

@Lxxyx Lxxyx Lxxyx approved these changes

@didacta didacta didacta approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@addaleax addaleax addaleax approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@bl-ue @jasnell @Trott @addaleax @targos @cjihrig @didacta @Lxxyx @RaisinTen