Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto: fix label cast in EVP_PKEY_CTX_set0_rsa_oaep_label #38926

Closed
wants to merge 1 commit into from
Closed

crypto: fix label cast in EVP_PKEY_CTX_set0_rsa_oaep_label #38926

wants to merge 1 commit into from

Conversation

codebytere
Copy link
Member

Corrects cast for label as passed to EVP_PKEY_CTX_set0_rsa_oaep_label

This has already been done here and causes BoringSSL failures if not cast from void*.

@codebytere codebytere requested a review from jasnell June 4, 2021 09:18
@github-actions github-actions bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Jun 4, 2021
@codebytere codebytere requested a review from tniessen June 4, 2021 09:18
@codebytere codebytere force-pushed the fix-EVP_PKEY_CTX_set0_rsa_oaep_label-cast branch from f6e68b1 to d0e22e7 Compare June 4, 2021 09:25
addaleax
addaleax approved these changes Jun 5, 2021
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but we always use static_cast when possible – feel free to update the other use of this as well

src/crypto/crypto_rsa.cc Outdated Show resolved Hide resolved
@codebytere codebytere force-pushed the fix-EVP_PKEY_CTX_set0_rsa_oaep_label-cast branch from d0e22e7 to 474fa4f Compare June 5, 2021 17:27
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/38503/

codebytere added a commit that referenced this pull request Jun 6, 2021
@codebytere
crypto: fix label cast in EVP_PKEY_CTX_set0_rsa_oaep_label
d07c12f 
PR-URL: #38926
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@codebytere
Copy link
Member Author

Landed in d07c12f

@codebytere codebytere closed this Jun 6, 2021
@codebytere codebytere deleted the fix-EVP_PKEY_CTX_set0_rsa_oaep_label-cast branch June 6, 2021 19:21
targos pushed a commit that referenced this pull request Jun 11, 2021
@codebytere @targos
crypto: fix label cast in EVP_PKEY_CTX_set0_rsa_oaep_label
6d5dc63 
PR-URL: #38926
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@danielleadams danielleadams mentioned this pull request Jun 14, 2021
Merged
@codebytere codebytere mentioned this pull request Jun 16, 2021
Merged
5 tasks
@richardlau
Copy link
Member

Doesn't land cleanly on v14.x-staging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bl-ue bl-ue bl-ue approved these changes

@RaisinTen RaisinTen RaisinTen left review comments

@addaleax addaleax addaleax approved these changes

@tniessen tniessen tniessen approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell Awaiting requested review from jasnell

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@codebytere @nodejs-github-bot @richardlau @Trott @addaleax @tniessen @RaisinTen @bl-ue