Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add missing semis after classes #38931

Closed

Conversation

RaisinTen
Copy link
Contributor

Signed-off-by: Darshan Sen raisinten@gmail.com

Signed-off-by: Darshan Sen <raisinten@gmail.com>
@github-actions github-actions bot added the doc Issues and PRs related to the documentations. label Jun 4, 2021
Copy link
Contributor

@bl-ue bl-ue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But this should be caught by the linter. 🤔

@Trott
Copy link
Member

Trott commented Jun 4, 2021

But this should be caught by the linter. 🤔

JS linter runs on the docs but not the C++ linter.

@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 5, 2021
@Lxxyx Lxxyx added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 10, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 10, 2021
@github-actions
Copy link
Contributor

Landed in cf609cc...ad27e0e

@github-actions github-actions bot closed this Jun 10, 2021
nodejs-github-bot pushed a commit that referenced this pull request Jun 10, 2021
Signed-off-by: Darshan Sen <raisinten@gmail.com>

PR-URL: #38931
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@bl-ue
Copy link
Contributor

bl-ue commented Jun 11, 2021

May I please ask: why commit-queue and not just land the PR yourself? 👀

@Lxxyx
Copy link
Member

Lxxyx commented Jun 11, 2021

May I please ask: why commit-queue and not just land the PR yourself? 👀

Actually because I was using my phone and not my computer at the time

targos pushed a commit that referenced this pull request Jun 11, 2021
Signed-off-by: Darshan Sen <raisinten@gmail.com>

PR-URL: #38931
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@RaisinTen RaisinTen deleted the doc/add-missing-semis-after-classes branch June 11, 2021 13:14
@bl-ue
Copy link
Contributor

bl-ue commented Jun 14, 2021

Actually because I was using my phone and not my computer at the time

Ah, simple enough! 😆 Thanks!

@danielleadams danielleadams mentioned this pull request Jun 14, 2021
danielleadams pushed a commit that referenced this pull request Jun 17, 2021
Signed-off-by: Darshan Sen <raisinten@gmail.com>

PR-URL: #38931
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
richardlau pushed a commit that referenced this pull request Jul 19, 2021
Signed-off-by: Darshan Sen <raisinten@gmail.com>

PR-URL: #38931
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
richardlau pushed a commit that referenced this pull request Jul 20, 2021
Signed-off-by: Darshan Sen <raisinten@gmail.com>

PR-URL: #38931
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@richardlau richardlau mentioned this pull request Jul 20, 2021
foxxyz pushed a commit to foxxyz/node that referenced this pull request Oct 18, 2021
Signed-off-by: Darshan Sen <raisinten@gmail.com>

PR-URL: nodejs#38931
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants