-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: remove --experimental-abortcontroller
documentation
#38968
doc: remove --experimental-abortcontroller
documentation
#38968
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deleting a command-line flag is semver-major. It's marked as a non-op, which is appropriate for now. Let's hold off removing it for a while.
Fwiw, I think removing this from the docs for the current version is fine, but we’re not really getting anything out of removing the flag instead of having it be a no-op. |
Is it the right time to remove it now? |
@iam-frankqiu At the risk of repeating what I’ve said before – I don’t think there’s any reason to remove the flag from the source code at any point in time. However, if you want to remove the flag from the documentation, I think we can do that right now. |
Thank you. What I want to do is just make node.js simpler and cleaner. |
@addaleax I think that something flagged as speaking of that's not what I understand of "experimenting". experimenting means I can break things, hence we flag it. "be aware! it might (and will) break!" but I think people have gotten used to the fact that node.js experimental stuff does not break. when I run any given project of mine I get more or less experimental warnings of some 3rd party modules using node.js built-ins. if an application developer is using an experimental flag, I'm pretty sure it's easy to remove, and was set with the same mindset of being eventually removed. heck, most (if not all) of the companies don't even want you to use any "experimental" flags in production. because the word alone sounds brittle and unstable. |
--experimental-abortcontroller
documentation
I can think of several recent changes to some Node.js experimental API changes, but let's not debate on this. I think Anna's point is:
Consider this: keeping the flag allows users to use |
To add on to what @aduh95 said –
Great, then it sounds like this is working as it should? |
Also, for some more context, we specifically put this into our Collaborator guide to avoid having this discussion over and over again:
|
6c11735
to
277146b
Compare
@jasnell are you still -1 on this now that the change is doc-only? |
PR-URL: #38968 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Landed in 24292b4 |
PR-URL: #38968 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com>
PR-URL: #38968 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com>
PR-URL: #38968 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com>
According to the docs.
AbortController and AbortSignal support is enabled by default. So I think we should delete this option.