Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

module: fix legacy node specifier resolution to resolve "main" field #38979

Merged
merged 1 commit into from
Jun 13, 2021
Merged

module: fix legacy node specifier resolution to resolve "main" field #38979

merged 1 commit into from
Jun 13, 2021

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jun 9, 2021 •
edited
Loading

Fixes: #38739
Fixes: #32103

@github-actions github-actions bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. labels Jun 9, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/38549/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/38550/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/38553/

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 11, 2021
@aduh95
Copy link
Contributor Author

aduh95 commented Jun 11, 2021

@nodejs/modules FYI

ljharb
ljharb reviewed Jun 11, 2021
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@zackschuster
Copy link

what's the rationale for allowing this? iirc exports replaces main entirely, with the intent of deprecating & removing main. cc @ljharb since i saw your dissent in the other issue & your LGTM here.

(+0 on this change, if curious; i do not wish to block anything)

@ljharb
Copy link
Member

ljharb commented Jun 12, 2021

“exports” isn’t required; packages aren’t going to be forced to use it and its encapsulation feature. “main” isn’t deprecated.

@aduh95
module: fix legacy node specifier resolution to resolve "main" field
4e17ffc 
PR-URL: nodejs#38979
Fixes: nodejs#32103
Fixes: nodejs#38739
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
@aduh95 aduh95 merged commit 4e17ffc into nodejs:master Jun 13, 2021
@aduh95 aduh95 deleted the resolve-main-node branch June 13, 2021 14:23
@aduh95
Copy link
Contributor Author

aduh95 commented Jun 13, 2021

Landed in 4e17ffc

@aduh95 aduh95 mentioned this pull request Jun 13, 2021
Closed
3 tasks
danielleadams pushed a commit that referenced this pull request Jun 14, 2021
@aduh95 @danielleadams
module: fix legacy node specifier resolution to resolve "main" field
92ed1c6 
PR-URL: #38979
Fixes: #32103
Fixes: #38739
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
@danielleadams danielleadams mentioned this pull request Jun 14, 2021
Merged
danielleadams pushed a commit that referenced this pull request Jun 17, 2021
@aduh95 @danielleadams
module: fix legacy node specifier resolution to resolve "main" field
51be97d 
PR-URL: #38979
Fixes: #32103
Fixes: #38739
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
richardlau pushed a commit that referenced this pull request Jul 19, 2021
@aduh95 @richardlau
module: fix legacy node specifier resolution to resolve "main" field
3bc3d11 
PR-URL: #38979
Fixes: #32103
Fixes: #38739
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
richardlau pushed a commit that referenced this pull request Jul 20, 2021
@aduh95 @richardlau
module: fix legacy node specifier resolution to resolve "main" field
afb6178 
PR-URL: #38979
Fixes: #32103
Fixes: #38739
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
@richardlau richardlau mentioned this pull request Jul 20, 2021
Merged
@aduh95 aduh95 mentioned this pull request Jul 23, 2021
Closed
aduh95 added a commit to aduh95/node that referenced this pull request Jul 23, 2021
@aduh95
module: fix legacy node specifier resolution to resolve "main" field
5f22ec4 
PR-URL: nodejs#38979
Fixes: nodejs#32103
Fixes: nodejs#38739
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
aduh95 added a commit to aduh95/node that referenced this pull request Jul 28, 2021
@aduh95
module: fix legacy node specifier resolution to resolve "main" field
43724ac 
PR-URL: nodejs#38979
Fixes: nodejs#32103
Fixes: nodejs#38739
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
richardlau pushed a commit that referenced this pull request Jul 28, 2021
@aduh95 @richardlau
module: fix legacy node specifier resolution to resolve "main" field
f0bb3d2 
PR-URL: #38979
Backport-PR-URL: #39497
Fixes: #32103
Fixes: #38739
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
richardlau pushed a commit that referenced this pull request Jul 28, 2021
@aduh95 @richardlau
module: fix legacy node specifier resolution to resolve "main" field
3e4bc1b 
PR-URL: #38979
Backport-PR-URL: #39497
Fixes: #32103
Fixes: #38739
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
@richardlau richardlau mentioned this pull request Jul 28, 2021
Merged
foxxyz pushed a commit to foxxyz/node that referenced this pull request Oct 18, 2021
@aduh95 @foxxyz
module: fix legacy node specifier resolution to resolve "main" field
8df2479 
PR-URL: nodejs#38979
Fixes: nodejs#32103
Fixes: nodejs#38739
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaisinTen RaisinTen RaisinTen left review comments

@ljharb ljharb ljharb left review comments

@guybedford guybedford guybedford approved these changes

@bmeck bmeck bmeck approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
7 participants
@aduh95 @nodejs-github-bot @zackschuster @ljharb @bmeck @guybedford @RaisinTen