test: remove obsolete TLS test #39001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
needs-ci
Lxxyx
approved these changes
Jun 11, 2021
Lxxyx
added
request-ci
github-actions
bot
removed
the
request-ci
jasnell
approved these changes
Jun 11, 2021
lpinca
approved these changes
Jun 11, 2021
cjihrig
approved these changes
Jun 12, 2021
|
Internet tests don't run in the regular Jenkins CI, so here's a run of the daily CI that does run internet tests: CI: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/21177/ ✅ |
The test involving melissadata.net was to make sure Node.js still tolerated ValiCert 1024-bit certs. It has been several years since melissadata.net used ValiCert as a root certificate and for that matter, we removed ValiCert in a4dbf45 so it would have broken then if it was still using it. The test is no longer valid or needed and hasn't been for several years. PR-URL: nodejs#39001 Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
Landed in 5b3587d |
danielleadams
pushed a commit
that referenced
this pull request
Jun 14, 2021
The test involving melissadata.net was to make sure Node.js still tolerated ValiCert 1024-bit certs. It has been several years since melissadata.net used ValiCert as a root certificate and for that matter, we removed ValiCert in a4dbf45 so it would have broken then if it was still using it. The test is no longer valid or needed and hasn't been for several years. PR-URL: #39001 Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
danielleadams
pushed a commit
that referenced
this pull request
Jun 17, 2021
The test involving melissadata.net was to make sure Node.js still tolerated ValiCert 1024-bit certs. It has been several years since melissadata.net used ValiCert as a root certificate and for that matter, we removed ValiCert in a4dbf45 so it would have broken then if it was still using it. The test is no longer valid or needed and hasn't been for several years. PR-URL: #39001 Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
richardlau
pushed a commit
that referenced
this pull request
Jul 19, 2021
The test involving melissadata.net was to make sure Node.js still tolerated ValiCert 1024-bit certs. It has been several years since melissadata.net used ValiCert as a root certificate and for that matter, we removed ValiCert in a4dbf45 so it would have broken then if it was still using it. The test is no longer valid or needed and hasn't been for several years. PR-URL: #39001 Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
richardlau
pushed a commit
that referenced
this pull request
Jul 20, 2021
The test involving melissadata.net was to make sure Node.js still tolerated ValiCert 1024-bit certs. It has been several years since melissadata.net used ValiCert as a root certificate and for that matter, we removed ValiCert in a4dbf45 so it would have broken then if it was still using it. The test is no longer valid or needed and hasn't been for several years. PR-URL: #39001 Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
foxxyz
pushed a commit
to foxxyz/node
that referenced
this pull request
Oct 18, 2021
The test involving melissadata.net was to make sure Node.js still tolerated ValiCert 1024-bit certs. It has been several years since melissadata.net used ValiCert as a root certificate and for that matter, we removed ValiCert in a4dbf45 so it would have broken then if it was still using it. The test is no longer valid or needed and hasn't been for several years. PR-URL: nodejs#39001 Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test involving melissadata.net was to make sure Node.js still
tolerated ValiCert 1024-bit certs. It has been several years since
melissadata.net used ValiCert as a root certificate and for that matter,
we removed ValiCert in a4dbf45 so it
would have broken then if it was still using it. The test is no longer
valid or needed and hasn't been for several years.