Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use localhost test instead of connecting to remote #39011

Closed
wants to merge 1 commit into from
Closed

test: use localhost test instead of connecting to remote #39011

wants to merge 1 commit into from

Conversation

AdamMajer
Copy link
Contributor

Fixes: #39008

@github-actions github-actions bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jun 11, 2021
lpinca
lpinca approved these changes Jun 11, 2021
View reviewed changes
test/parallel/test-https-agent-unref-socket.js Outdated Show resolved Hide resolved
@AdamMajer AdamMajer force-pushed the fragile_network_test branch from 485a2db to da3c17f Compare June 14, 2021 08:18
@RaisinTen RaisinTen added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jun 14, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 14, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/38622/

@Lxxyx Lxxyx removed the needs-ci PRs that need a full CI run. label Jun 14, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/38628/

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 26, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 26, 2021
@github-actions
Copy link
Contributor

Landed in 8a8c7f4...520ad58

@github-actions github-actions bot closed this Jun 26, 2021
nodejs-github-bot pushed a commit that referenced this pull request Jun 26, 2021
@AdamMajer @nodejs-github-bot
test: use localhost test instead of connecting to remote
520ad58 
Fixes: #39008

PR-URL: #39011
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
targos pushed a commit that referenced this pull request Jul 11, 2021
@AdamMajer @targos
test: use localhost test instead of connecting to remote
df17c62 
Fixes: #39008

PR-URL: #39011
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
@targos targos mentioned this pull request Jul 13, 2021
Merged
@batrla
Copy link
Contributor

batrla commented Aug 2, 2021

Please pull this fix to Node.js 14.x branch where test-https-agent-unref-socket.js is still broken without internet connection.

@batrla batrla mentioned this pull request Aug 13, 2021
Closed
@mhdawson
Copy link
Member

@batrla tagged for LTS watch. @BethGriggs anything else we need to do in order to get it into the process for being backported to 14.x?

@AdamMajer AdamMajer deleted the fragile_network_test branch August 30, 2021 13:14
@lpinca lpinca mentioned this pull request Aug 31, 2021
Open
@targos
Copy link
Member

targos commented Sep 4, 2021

Landed on v14.x-staging

targos pushed a commit that referenced this pull request Sep 4, 2021
@AdamMajer @targos
test: use localhost test instead of connecting to remote
f70fd00 
Fixes: #39008

PR-URL: #39011
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
@targos targos mentioned this pull request Sep 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaisinTen RaisinTen RaisinTen approved these changes

@Lxxyx Lxxyx Lxxyx approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test: parallel/test-https-agent-unref-socket requires external network connection
9 participants
@AdamMajer @nodejs-github-bot @batrla @mhdawson @targos @lpinca @Lxxyx @RaisinTen @aduh95