Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: refactor to use locale functions #39014

Closed

Conversation

RaisinTen
Copy link
Contributor

This makes the code more readable.

Signed-off-by: Darshan Sen raisinten@gmail.com

This makes the code more readable.

Signed-off-by: Darshan Sen <raisinten@gmail.com>
@github-actions github-actions bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Jun 12, 2021
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 13, 2021
@nodejs-github-bot
Copy link
Collaborator

@jasnell
Copy link
Member

jasnell commented Jun 14, 2021

Landed in 940f2c2

@jasnell jasnell closed this Jun 14, 2021
jasnell pushed a commit that referenced this pull request Jun 14, 2021
This makes the code more readable.

Signed-off-by: Darshan Sen <raisinten@gmail.com>

PR-URL: #39014
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@RaisinTen RaisinTen deleted the src/refactor-to-use-locale-functions branch June 14, 2021 15:22
danielleadams pushed a commit that referenced this pull request Jun 15, 2021
This makes the code more readable.

Signed-off-by: Darshan Sen <raisinten@gmail.com>

PR-URL: #39014
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadams danielleadams mentioned this pull request Jun 15, 2021
danielleadams pushed a commit that referenced this pull request Jun 17, 2021
This makes the code more readable.

Signed-off-by: Darshan Sen <raisinten@gmail.com>

PR-URL: #39014
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
richardlau pushed a commit that referenced this pull request Jul 19, 2021
This makes the code more readable.

Signed-off-by: Darshan Sen <raisinten@gmail.com>

PR-URL: #39014
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
richardlau pushed a commit that referenced this pull request Jul 20, 2021
This makes the code more readable.

Signed-off-by: Darshan Sen <raisinten@gmail.com>

PR-URL: #39014
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@richardlau richardlau mentioned this pull request Jul 20, 2021
foxxyz pushed a commit to foxxyz/node that referenced this pull request Oct 18, 2021
This makes the code more readable.

Signed-off-by: Darshan Sen <raisinten@gmail.com>

PR-URL: nodejs#39014
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants