Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: explained what node keyword does in terminal #39020

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

anshulshacks
Copy link
Contributor

I found the explanation for the example to be lacking a bit of clarity so cleared it up. Changed:

Save the file, go back to the terminal window, and enter the following command:

$ node hello-world.js

to:

Save the file and go back to the terminal. Entering the following commands run the file named hello-world.js:

$ node hello-world.js

@github-actions github-actions bot added the doc Issues and PRs related to the documentations. label Jun 12, 2021
@@ -69,7 +69,7 @@ server.listen(port, hostname, () => {
});
```

Save the file, go back to the terminal window, and enter the following command:
Save the file and go back to the terminal. Entering the following commands run the file named `hello-world.js`:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Save the file and go back to the terminal. Entering the following commands run the file named `hello-world.js`:
Save the file. Then, in the terminal window, to run the `hello-world.js` file,
enter:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(See table row for Enter at https://docs.microsoft.com/en-us/style-guide/procedures-instructions/describing-interactions-with-ui for relevant guidelines/examples on describing user interactions like this.)

@targos
Copy link
Member

targos commented Aug 9, 2021

@nodejs/documentation

Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 20, 2023
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 6, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 6, 2023
@nodejs-github-bot nodejs-github-bot merged commit 24dea23 into nodejs:main Oct 6, 2023
20 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 24dea23

alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
PR-URL: nodejs#39020
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit that referenced this pull request Nov 11, 2023
PR-URL: #39020
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
debadree25 pushed a commit to debadree25/node that referenced this pull request Apr 15, 2024
PR-URL: nodejs#39020
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants