Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

errors: remove source map rekey logic #39025

Closed
wants to merge 5 commits into from
Closed

errors: remove source map rekey logic #39025

wants to merge 5 commits into from

Commits on Jun 13, 2021

  1. errors: don't rekey on primitive type 

    If an error is thrown before a module is loaded, we attempt to cache
source map against error object, rather than module object. We
can't do this if the error is a primitive type

Fixes nodejs#38945
    @bcoe
    bcoe committed Jun 13, 2021
    Configuration menu
    Copy the full SHA
    773ea75 View commit details
    Browse the repository at this point in the history

  2. Update lib/internal/source_map/source_map_cache.js 

    Co-authored-by: Rich Trott <rtrott@gmail.com>
    @bcoe @Trott
    bcoe and Trott authored Jun 13, 2021
    Configuration menu
    Copy the full SHA
    0b67b1e View commit details
    Browse the repository at this point in the history

  3. stop rekeying cjs cache

    @bcoe
    bcoe committed Jun 13, 2021
    Configuration menu
    Copy the full SHA
    9a7fad6 View commit details
    Browse the repository at this point in the history

  4. delete more code

    @bcoe
    bcoe committed Jun 13, 2021
    Configuration menu
    Copy the full SHA
    4af02fd View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2021

  1. test: update test to reflect refactor

    @bcoe
    bcoe committed Jun 15, 2021
    Configuration menu
    Copy the full SHA
    b56a914 View commit details
    Browse the repository at this point in the history