Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

riscv: allow to build riscv64 using Makefile #39048

Closed
wants to merge 1 commit into from

Conversation

makotokato
Copy link
Contributor

No description provided.

@github-actions github-actions bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Jun 15, 2021
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jun 16, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 16, 2021
@nodejs-github-bot
Copy link
Collaborator

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 26, 2021
@github-actions github-actions bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jun 26, 2021
@github-actions
Copy link
Contributor

Commit Queue failed
- Loading data for nodejs/node/pull/39048
✔  Done loading data for nodejs/node/pull/39048
----------------------------------- PR info ------------------------------------
Title      riscv: allow to build riscv64 using Makefile (#39048)
Author     Makoto Kato  (@makotokato, first-time contributor)
Branch     makotokato:riscv64-make -> nodejs:master
Labels     author ready, build, needs-ci
Commits    1
 - riscv: allow to build riscv64 using Makefile
Committers 1
 - Makoto Kato 
PR-URL: https://github.com/nodejs/node/pull/39048
Reviewed-By: Richard Lau 
Reviewed-By: Michaël Zasso 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/39048
Reviewed-By: Richard Lau 
Reviewed-By: Michaël Zasso 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 15 Jun 2021 23:19:43 GMT
   ✔  Approvals: 2
   ✔  - Richard Lau (@richardlau): https://github.com/nodejs/node/pull/39048#pullrequestreview-684705782
   ✔  - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/39048#pullrequestreview-684890249
   ✔  Last GitHub Actions successful
   ℹ  Last Full PR CI on 2021-06-16T08:39:08Z: https://ci.nodejs.org/job/node-test-pull-request/38647/
- Querying data for job/node-test-pull-request/38647/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/master up to date...
From https://github.com/nodejs/node
 * branch                  master     -> FETCH_HEAD
   520ad58658..19b80cc4ec  master     -> origin/master
✔  origin/master is now up-to-date
master is out of sync with origin/master. Mismatched commits:
 - 19b80cc4ec build: fix building with external builtins
--------------------------------------------------------------------------------
HEAD is now at 19b80cc4ec build: fix building with external builtins
   ✔  Reset to origin/master
- Downloading patch for 39048
From https://github.com/nodejs/node
 * branch                  refs/pull/39048/merge -> FETCH_HEAD
✔  Fetched commits as 19b80cc4ece0..fe29a2032402
--------------------------------------------------------------------------------
Auto-merging Makefile
[master d5d0d15105] riscv: allow to build riscv64 using Makefile
 Author: Makoto Kato 
 Date: Wed Jun 16 08:12:42 2021 +0900
 1 file changed, 8 insertions(+)
   ✔  Patches applied
--------------------------------------------------------------------------------
--------------------------------- New Message ----------------------------------
riscv: allow to build riscv64 using Makefile

PR-URL: #39048
Reviewed-By: Richard Lau rlau@redhat.com
Reviewed-By: Michaël Zasso targos@protonmail.com

[master 68dd865e0b] riscv: allow to build riscv64 using Makefile
Author: Makoto Kato m_kato@ga2.so-net.ne.jp
Date: Wed Jun 16 08:12:42 2021 +0900
1 file changed, 8 insertions(+)
✖ 68dd865e0ba7600f257d84fc472983508859b2f2
✔ 0:0 skipping fixes-url fixes-url
✔ 0:0 blank line after title line-after-title
✔ 0:0 line-lengths are valid line-length
✔ 0:0 metadata is at end of message metadata-end
✔ 1:8 PR-URL is valid. pr-url
✔ 0:0 reviewers are valid reviewers
✖ 0:0 Invalid subsystem: "riscv" subsystem
✔ 0:0 Title is formatted correctly. title-format
✔ 0:0 Title is <= 50 columns. title-length

ℹ Please fix the commit message and try again.

https://github.com/nodejs/node/actions/runs/974326765

targos pushed a commit that referenced this pull request Jul 11, 2021
PR-URL: #39048
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@targos
Copy link
Member

targos commented Jul 11, 2021

Landed in 0b27fd0

@targos targos closed this Jul 11, 2021
targos pushed a commit that referenced this pull request Jul 11, 2021
PR-URL: #39048
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@targos targos added dont-land-on-v14.x and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Sep 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants