build: pass directory instead of list of files to js2c.py

[joyeecheung]

The first commit comes from #39066 (without it changes in node.gyp alone won't trigger a rebuild)

On Windows there is a limit to the length of commands, so there
will be an error once the lengths of the JS file names combined
exceed that limit. This patch modifies js2c.py so that
it now takes a --directory argument to glob for .js and
.mjs files in addition to the list of files passed directly.
We still pass the additional files we include from deps/
directly through the command line, as we only includes some of
them so we cannot simply glob, but those are limited so listing
them out should be fine.

Refs: https://docs.microsoft.com/en-us/troubleshoot/windows-client/shell-experience/command-line-string-limitation
Refs: #38971

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/38672/

[joyeecheung]

From #38971, in case anyone is curious, when the command passed to js2c.py is too long for Windows, the error looks like this (something weird is going on with the arguments it receives):

Traceback (most recent call last):
    File "D:\a\node\node\tools\js2c.py", line 222, in <module>
      main()
    File "D:\a\node\node\tools\js2c.py", line 218, in main
      JS2C(source_files, options.target)
    File "D:\a\node\node\tools\js2c.py", line 153, in JS2C
      write_if_chaged(out, target)
    File "D:\a\node\node\tools\js2c.py", line 187, in write_if_chaged
      with open(target, "wt") as output:
  FileNotFoundError: [Errno 2] No such file or directory: 'out\\Reease\\bj/global_intermediate/node_javascript.cc'
  js-heap-broker.cc
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Microsoft\VC\v160\Microsoft.CppCommon.targets(241,5): error MSB8066: Custom build for 'tools\js2c.py;src\inspector\node_protocol.pdl;src\inspector\node_protocol_config.json;deps\v8\include\js_protocol.pdl;out\Release\\obj\global_intermediate\concatenated_protocol.json;deps\openssl\openssl\util\libcrypto.num' exited with code 1. [D:\a\node\node\libnode.vcxproj]

[joyeecheung]

cc @nodejs/build @nodejs/platform-windows

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/38692/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/38700/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/38713/

[joyeecheung]

Rebased

[targos]

@nodejs/python

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/38751/

[jasnell]

Landed in 44ecd41

[lpinca]

utils.py now throws an error on macOS 11.4 (Python 3.8.2).

$ make -j8
/Library/Developer/CommandLineTools/usr/bin/python3 tools/gyp_node.py -f make
Traceback (most recent call last):
  File "tools/search_files.py", line 22, in <module>
    main()
  File "tools/search_files.py", line 19, in main
    print('\n'.join(utils.SearchFiles(options.directory, options.ext)))
  File "/Users/luigi/code/node/tools/utils.py", line 114, in SearchFiles
    list = glob.glob(dir+ '/**/*.' + ext, recursive=True)
TypeError: glob() got an unexpected keyword argument 'recursive'
gyp: Call to 'python tools/search_files.py --ext js lib' returned exit status 1 while in /Users/luigi/code/node/node.gyp.

I'll open a proper issue later.

[lpinca]

It seems this happens because Python 2 is used instead of Python 3.

[lpinca]

make clean fixed the issue.