doc: replace outdated util.promisify timer examples with references to new awaitable timers
#39164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
doc
aduh95
reviewed
Jun 27, 2021
foxxyz
force-pushed
the
timers-doc-fix
branch
2 times, most recently
from
738ebc1
to
bc480ea
Compare
|
Re-pushed commits to keep commit messages below the 72 char limit as indicated by CI. |
aduh95
approved these changes
Jun 27, 2021
aduh95
added
the
author ready
jasnell
approved these changes
Jun 28, 2021
targos
pushed a commit
that referenced
this pull request
Jul 11, 2021
PR-URL: #39164 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in 72f198b |
targos
pushed a commit
that referenced
this pull request
Jul 11, 2021
PR-URL: #39164 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the new awaitable timers graduated in 16.0.0, the references to using
util.promisifyto promisify the callback versions ofsetTimeout(),setImmediate(), etc, are confusing and likely outdated.This PR removes the
util.promisifycode samples and links to thetimers/promisesvariants instead.Furthermore, it adds a link to the async iterator version of
setInterval()in the respective docs for the callback-based version.