Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: patch V8 to 9.1.269.38 #39196

Closed
wants to merge 1 commit into from
Closed

Conversation

targos
Copy link
Member

@targos targos commented Jun 29, 2021

@github-actions github-actions bot added needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Jun 29, 2021
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 30, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 30, 2021
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 30, 2021

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 9, 2021

@targos targos added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dont-land-on-v12.x labels Jul 9, 2021
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@targos targos added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 10, 2021
@github-actions github-actions bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jul 10, 2021
@github-actions
Copy link
Contributor

Commit Queue failed
- Loading data for nodejs/node/pull/39196
✔  Done loading data for nodejs/node/pull/39196
----------------------------------- PR info ------------------------------------
Title      deps: patch V8 to 9.1.269.38 (#39196)
Author     Michaël Zasso  (@targos)
Branch     targos:patch-v8-91 -> nodejs:master
Labels     author ready, backport-open-v14.x, dont-land-on-v12.x, needs-ci, v8 engine
Commits    1
 - deps: patch V8 to 9.1.269.38
Committers 1
 - Michaël Zasso 
PR-URL: https://github.com/nodejs/node/pull/39196
Fixes: https://github.com/nodejs/node/issues/37553
Refs: https://github.com/v8/v8/compare/9.1.269.36...9.1.269.38
Reviewed-By: Richard Lau 
Reviewed-By: Gireesh Punathil 
Reviewed-By: Jiawen Geng 
Reviewed-By: Matteo Collina 
Reviewed-By: Tobias Nießen 
Reviewed-By: Colin Ihrig 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/39196
Fixes: https://github.com/nodejs/node/issues/37553
Refs: https://github.com/v8/v8/compare/9.1.269.36...9.1.269.38
Reviewed-By: Richard Lau 
Reviewed-By: Gireesh Punathil 
Reviewed-By: Jiawen Geng 
Reviewed-By: Matteo Collina 
Reviewed-By: Tobias Nießen 
Reviewed-By: Colin Ihrig 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last review:
   ⚠  - deps: patch V8 to 9.1.269.38
   ℹ  This PR was created on Tue, 29 Jun 2021 18:42:34 GMT
   ✔  Approvals: 6
   ✔  - Richard Lau (@richardlau): https://github.com/nodejs/node/pull/39196#pullrequestreview-695388471
   ✔  - Gireesh Punathil (@gireeshpunathil) (TSC): https://github.com/nodejs/node/pull/39196#pullrequestreview-695638866
   ✔  - Jiawen Geng (@gengjiawen): https://github.com/nodejs/node/pull/39196#pullrequestreview-695639089
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/39196#pullrequestreview-695711864
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/39196#pullrequestreview-701145607
   ✔  - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/39196#pullrequestreview-701545529
   ✔  Last GitHub Actions successful
   ℹ  Last Full PR CI on 2021-07-10T06:33:31Z: https://ci.nodejs.org/job/node-test-pull-request/38934/
   ℹ  Last V8 CI on 2021-07-09T11:58:35Z: https://ci.nodejs.org/job/node-test-commit-v8-linux/4127/
- Querying data for job/node-test-pull-request/38934/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/1017514995

@targos
Copy link
Member Author

targos commented Jul 10, 2021

Landed in e2148d7

@targos targos closed this Jul 10, 2021
@targos targos deleted the patch-v8-91 branch July 10, 2021 07:38
targos added a commit that referenced this pull request Jul 10, 2021
Refs: v8/v8@9.1.269.36...9.1.269.38
Fixes: #37553

PR-URL: #39196
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos added a commit that referenced this pull request Jul 11, 2021
Refs: v8/v8@9.1.269.36...9.1.269.38
Fixes: #37553

PR-URL: #39196
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@targos targos added backported-to-v14.x and removed backport-open-v14.x commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node.js v14.15.5 segfault in v8::internal::ConcurrentMarking::Run
8 participants