Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc,tools: remove checkLinks.mjs #39206

Merged
merged 1 commit into from
Jul 23, 2021
Merged

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jun 30, 2021

The checks made by this are now integrated to remark-preset-lint-node, there are no reason to keep it around anymore.

Blocked on #39201 (first commit is from there).

@github-actions github-actions bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Jun 30, 2021
@aduh95 aduh95 removed the needs-ci PRs that need a full CI run. label Jun 30, 2021
@aduh95 aduh95 mentioned this pull request Jul 21, 2021
@aduh95 aduh95 added the review wanted PRs that need reviews. label Jul 22, 2021
@aduh95 aduh95 requested a review from Trott July 22, 2021 22:12
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be rebased to get rid of the commit from #39201?

The checks made by this are now integrated to `remark-preset-lint-node`,
there are no reason to keep it around anymore.

PR-URL: nodejs#39206
Reviewed-By: Rich Trott <rtrott@gmail.com>
@aduh95
Copy link
Contributor Author

aduh95 commented Jul 23, 2021

Landed in ab73d95

@aduh95 aduh95 merged commit ab73d95 into nodejs:master Jul 23, 2021
@aduh95 aduh95 deleted the remove-checkLinks branch July 23, 2021 07:39
targos pushed a commit that referenced this pull request Jul 25, 2021
The checks made by this are now integrated to `remark-preset-lint-node`,
there are no reason to keep it around anymore.

PR-URL: #39206
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Jul 26, 2021
richardlau pushed a commit that referenced this pull request Jul 29, 2021
The checks made by this are now integrated to `remark-preset-lint-node`,
there are no reason to keep it around anymore.

PR-URL: #39206
Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs pushed a commit that referenced this pull request Jul 29, 2021
The checks made by this are now integrated to `remark-preset-lint-node`,
there are no reason to keep it around anymore.

PR-URL: #39206
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Sep 4, 2021
The checks made by this are now integrated to `remark-preset-lint-node`,
there are no reason to keep it around anymore.

PR-URL: #39206
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. review wanted PRs that need reviews. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants