Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: update ESLint to 7.30.0 #39242

Closed
wants to merge 1 commit into from
Closed

tools: update ESLint to 7.30.0 #39242

wants to merge 1 commit into from

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Jul 3, 2021

Update ESLint to 7.30.0

@cjihrig
tools: update ESLint to 7.30.0
525c6ca 
Update ESLint to 7.30.0
@github-actions github-actions bot added the tools Issues and PRs related to the tools directory. label Jul 3, 2021
Trott
Trott approved these changes Jul 3, 2021
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamp LGTM. Wonder if we should move things like this to PRs opened by a bot or GitHub Actions. The current system is working fine, but that's mostly because there's personal trust here.

@cjihrig cjihrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 5, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 5, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2021

Landed in 70cf0dc...6dfdb0a

@github-actions github-actions bot closed this Jul 5, 2021
nodejs-github-bot pushed a commit that referenced this pull request Jul 5, 2021
@cjihrig @nodejs-github-bot
tools: update ESLint to 7.30.0
6dfdb0a 
Update ESLint to 7.30.0

PR-URL: #39242
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@cjihrig cjihrig deleted the eslint branch July 5, 2021 20:11
targos pushed a commit that referenced this pull request Jul 11, 2021
@cjihrig @targos
tools: update ESLint to 7.30.0
cb8c6ff 
Update ESLint to 7.30.0

PR-URL: #39242
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Jul 13, 2021
Merged
targos pushed a commit that referenced this pull request Sep 4, 2021
@cjihrig @targos
tools: update ESLint to 7.30.0
f0e0c8f 
Update ESLint to 7.30.0

PR-URL: #39242
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Sep 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lxxyx Lxxyx Lxxyx approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cjihrig @Trott @lpinca @Lxxyx