Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: pass bot token to node-pr-labeler #39271

Closed
wants to merge 1 commit into from
Closed

Conversation

targos
Copy link
Member

@targos targos commented Jul 5, 2021

This should allow workflows that use the labeled event to be run.

Currently, fast-track requests for npm updates do not result in a comment: #39225 (comment)

This should allow workflows that use the `labeled` event to be run.
@github-actions github-actions bot added the meta Issues and PRs related to the general management of the project. label Jul 5, 2021
@targos
Copy link
Member Author

targos commented Jul 7, 2021

@nodejs/actions

@targos targos added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 9, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 9, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2021

Commit Queue failed
- Loading data for nodejs/node/pull/39271
✔  Done loading data for nodejs/node/pull/39271
----------------------------------- PR info ------------------------------------
Title      tools: pass bot token to node-pr-labeler (#39271)
Author     Michaël Zasso  (@targos)
Branch     targos:targos-patch-1 -> nodejs:master
Labels     meta
Commits    1
 - tools: pass bot token to node-pr-labeler
Committers 1
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/39271
Reviewed-By: James M Snell 
Reviewed-By: Jiawen Geng 
Reviewed-By: Tobias Nießen 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/39271
Reviewed-By: James M Snell 
Reviewed-By: Jiawen Geng 
Reviewed-By: Tobias Nießen 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Mon, 05 Jul 2021 13:50:27 GMT
   ✔  Approvals: 3
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/39271#pullrequestreview-701555483
   ✔  - Jiawen Geng (@gengjiawen): https://github.com/nodejs/node/pull/39271#pullrequestreview-701570794
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/39271#pullrequestreview-702952670
   ✖  GitHub CI is still running
   ℹ  Green GitHub Actions CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/1015485730

@github-actions github-actions bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Jul 9, 2021
@targos
Copy link
Member Author

targos commented Jul 9, 2021

GitHub CI is still running?

@targos
Copy link
Member Author

targos commented Jul 9, 2021

I assume it's a bug with GitHub. The API reports a check that is queued, but it doesn't exist...

@targos
Copy link
Member Author

targos commented Jul 9, 2021

Landed in e4462bd

@targos targos closed this Jul 9, 2021
targos added a commit that referenced this pull request Jul 9, 2021
This should allow workflows that use the `labeled` event to be run.

PR-URL: #39271
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@targos targos deleted the targos-patch-1 branch July 9, 2021 15:03
targos added a commit that referenced this pull request Jul 11, 2021
This should allow workflows that use the `labeled` event to be run.

PR-URL: #39271
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos added a commit that referenced this pull request Sep 4, 2021
This should allow workflows that use the `labeled` event to be run.

PR-URL: #39271
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@targos targos removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants