New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add test for debugger restart message issue #39273

Merged

Trott merged 1 commit into nodejs:master from Trott:restart-twice

Jul 8, 2021

Member

Trott commented Jul 5, 2021

Running "restart" in the debugger confusingly prints an out-of-date
"Debugger listening on..." message before printing a second updated one.

Refs: #39272

github-actions bot added needs-ci test labels

Trott added the request-ci label

github-actions bot removed the request-ci label

This comment has been minimized.

Sign in to view

Member Author

Trott commented Jul 5, 2021

Argh, the bug happens unreliably. It usually happens but not always.

Trott force-pushed the restart-twice branch from d91011a to 03556e5 Compare

July 5, 2021 16:23

Member Author

Trott commented Jul 5, 2021 •

edited

Loading

Changed it to restart 32 64 times to try to make sure the error happens reliably. When this is moved out of known_issues, it can be reduced to 1 or 2.

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

Trott force-pushed the restart-twice branch from 8f7cb4f to 241746a Compare

July 6, 2021 02:32

This comment has been minimized.

Sign in to view

Trott force-pushed the restart-twice branch from 241746a to f1dc048 Compare

July 6, 2021 04:10

This comment has been minimized.

Sign in to view

Trott force-pushed the restart-twice branch from f1dc048 to 9226bc3 Compare

July 7, 2021 04:06

This comment has been minimized.

Sign in to view

Trott force-pushed the restart-twice branch from 9226bc3 to c43e9ab Compare

July 7, 2021 04:34

This comment has been minimized.

Sign in to view

Collaborator

nodejs-github-bot commented Jul 7, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/38886/

Member Author

Trott commented Jul 7, 2021

@nodejs/testing

cjihrig approved these changes

View reviewed changes

jasnell approved these changes

View reviewed changes


          test: add test for debugger restart message issue

b2fa795

Running "restart" in the debugger confusingly prints an out-of-date
"Debugger listening on..." message before printing a second updated one.

Refs: nodejs#39272

PR-URL: nodejs#39273
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Trott force-pushed the restart-twice branch from c43e9ab to b2fa795 Compare

July 8, 2021 03:57

Member Author

Trott commented Jul 8, 2021

Landed in b2fa795

Trott merged commit b2fa795 into nodejs:master

Trott deleted the restart-twice branch

July 8, 2021 03:57

targos pushed a commit that referenced this pull request


          test: add test for debugger restart message issue

8e77aa2

Running "restart" in the debugger confusingly prints an out-of-date
"Debugger listening on..." message before printing a second updated one.

Refs: #39272

PR-URL: #39273
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

targos mentioned this pull request

v16.5.0 release proposal #39373

Merged

targos pushed a commit that referenced this pull request


          test: add test for debugger restart message issue

9b737eb

Running "restart" in the debugger confusingly prints an out-of-date
"Debugger listening on..." message before printing a second updated one.

Refs: #39272

PR-URL: #39273
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

targos mentioned this pull request

v14.18.0 release proposal #39990

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels